Compare commits
32 Commits
feature/te
...
improvemen
| Author | SHA1 | Date | |
|---|---|---|---|
| 8520412867 | |||
| e94f61a697 | |||
| 0cd09d0878 | |||
| 994ba5d797 | |||
| af636fe6ea | |||
| 3ccb32e8e1 | |||
| af4e1c61aa | |||
| 8153aa56ce | |||
| b82c6fea38 | |||
| cb374bfa77 | |||
| 2b41490806 | |||
| 7186fa2cbe | |||
| da1deac44e | |||
| faae37e6ae | |||
| 6aefb046b6 | |||
| 2350cca32c | |||
| 671d259c44 | |||
| 28a1bb4b62 | |||
| 898e9b8163 | |||
| 48bf8526b9 | |||
| 7e4d2fa29b | |||
| 779604750e | |||
| aca9a2f307 | |||
| d14d9eba4c | |||
| 081ea4de1c | |||
| a075811173 | |||
| d4143da9fc | |||
| b0c9b89e94 | |||
|
|
94363d49ce | ||
|
|
8bca1bb3c7 | ||
|
|
1ce8eb15c0 | ||
|
|
4d2ffeea27 |
7
.gitignore
vendored
7
.gitignore
vendored
@@ -8,8 +8,11 @@ include/
|
||||
keys/
|
||||
.venv/
|
||||
.idea/
|
||||
|
||||
*.kate-swp
|
||||
|
||||
node_modules/
|
||||
package-lock.json
|
||||
package.json
|
||||
# Diagram cache directory
|
||||
media/diagram_cache/
|
||||
.env
|
||||
data/db.sqlite3
|
||||
|
||||
1599
R0066.json
Normal file
1599
R0066.json
Normal file
File diff suppressed because it is too large
Load Diff
102
admin/css/vorgabe_border.css
Normal file
102
admin/css/vorgabe_border.css
Normal file
@@ -0,0 +1,102 @@
|
||||
/* Better visual separation for Vorgaben inlines */
|
||||
.inline-group[data-inline-model="vorgabe"] {
|
||||
border: 2px solid #ddd;
|
||||
border-radius: 8px;
|
||||
margin-bottom: 20px;
|
||||
padding: 15px;
|
||||
background-color: #f9f9f9;
|
||||
box-shadow: 0 2px 4px rgba(0,0,0,0.1);
|
||||
}
|
||||
|
||||
.inline-group[data-inline-model="vorgabe"] .inline-related {
|
||||
border: 1px solid #ccc;
|
||||
border-radius: 6px;
|
||||
margin-bottom: 10px;
|
||||
background-color: white;
|
||||
padding: 10px;
|
||||
}
|
||||
|
||||
.inline-group[data-inline-model="vorgabe"] h3 {
|
||||
background-color: #007cba;
|
||||
color: white;
|
||||
padding: 8px 12px;
|
||||
margin: -15px -15px 10px -15px;
|
||||
border-radius: 6px 6px 0 0;
|
||||
font-weight: bold;
|
||||
}
|
||||
|
||||
.inline-group[data-inline-model="vorgabe"] .collapse .inline-related {
|
||||
border-left: 3px solid #007cba;
|
||||
}
|
||||
|
||||
/* Better spacing for nested inlines */
|
||||
.inline-group[data-inline-model="vorgabe"] .inline-group {
|
||||
margin-top: 10px;
|
||||
}
|
||||
|
||||
.inline-group[data-inline-model="vorgabe"] .inline-group h3 {
|
||||
background-color: #f0f8ff;
|
||||
color: #333;
|
||||
padding: 6px 10px;
|
||||
margin: 0 0 8px 0;
|
||||
border-left: 3px solid #007cba;
|
||||
}
|
||||
|
||||
/* Highlight active/expanded vorgabe */
|
||||
.inline-group[data-inline-model="vorgabe"] .inline-related:not(.collapsed) {
|
||||
border-color: #007cba;
|
||||
box-shadow: 0 0 8px rgba(0,124,186,0.2);
|
||||
}
|
||||
|
||||
/* Highlight actively edited vorgabe */
|
||||
.inline-group[data-inline-model="vorgabe"] .inline-related.active-edit {
|
||||
border-color: #28a745;
|
||||
box-shadow: 0 0 12px rgba(40,167,69,0.3);
|
||||
background-color: #f8fff9;
|
||||
}
|
||||
|
||||
/* Toggle hint styling */
|
||||
.toggle-hint {
|
||||
font-size: 0.8em;
|
||||
color: #666;
|
||||
font-weight: normal;
|
||||
}
|
||||
|
||||
/* Better fieldset styling for vorgabe inlines */
|
||||
.inline-group[data-inline-model="vorgabe"] .fieldset {
|
||||
border: 1px solid #e0e0e0;
|
||||
border-radius: 4px;
|
||||
padding: 10px;
|
||||
margin-bottom: 10px;
|
||||
background-color: #fafafa;
|
||||
}
|
||||
|
||||
.inline-group[data-inline-model="vorgabe"] .fieldset h2 {
|
||||
background-color: #e3f2fd;
|
||||
color: #1565c0;
|
||||
padding: 5px 10px;
|
||||
margin: -10px -10px 10px -10px;
|
||||
border-radius: 4px 4px 0 0;
|
||||
font-size: 0.9em;
|
||||
font-weight: bold;
|
||||
}
|
||||
|
||||
/* Better form layout */
|
||||
.inline-group[data-inline-model="vorgabe"] .form-row {
|
||||
border-bottom: 1px solid #eee;
|
||||
padding: 8px 0;
|
||||
}
|
||||
|
||||
.inline-group[data-inline-model="vorgabe"] .form-row:last-child {
|
||||
border-bottom: none;
|
||||
}
|
||||
|
||||
/* Wide fields styling */
|
||||
.inline-group[data-inline-model="vorgabe"] .wide .form-row > div {
|
||||
width: 100%;
|
||||
}
|
||||
|
||||
.inline-group[data-inline-model="vorgabe"] .wide textarea {
|
||||
width: 100%;
|
||||
min-height: 80px;
|
||||
}
|
||||
25
admin/js/vorgabe_toggle.js
Normal file
25
admin/js/vorgabe_toggle.js
Normal file
@@ -0,0 +1,25 @@
|
||||
(function($) {
|
||||
'use strict';
|
||||
|
||||
$(document).ready(function() {
|
||||
// Add toggle buttons for each vorgabe inline
|
||||
$('.inline-group[data-inline-model="vorgabe"]').each(function() {
|
||||
var $group = $(this);
|
||||
var $headers = $group.find('h3');
|
||||
|
||||
$headers.css('cursor', 'pointer').append(' <span class="toggle-hint">(klicken zum umschalten)</span>');
|
||||
|
||||
$headers.on('click', function(e) {
|
||||
e.preventDefault();
|
||||
var $inline = $(this).closest('.inline-related');
|
||||
$inline.find('.collapse').toggleClass('collapsed');
|
||||
});
|
||||
});
|
||||
|
||||
// Highlight active vorgabe when editing
|
||||
$('.inline-group[data-inline-model="vorgabe"] .inline-related').on('click', function() {
|
||||
$('.inline-group[data-inline-model="vorgabe"] .inline-related').removeClass('active-edit');
|
||||
$(this).addClass('active-edit');
|
||||
});
|
||||
});
|
||||
})(django.jQuery);
|
||||
@@ -18,14 +18,14 @@ spec:
|
||||
fsGroupChangePolicy: "OnRootMismatch"
|
||||
initContainers:
|
||||
- name: loader
|
||||
image: git.baumann.gr/adebaumann/vui-data-loader:0.8
|
||||
image: git.baumann.gr/adebaumann/vui-data-loader:0.9
|
||||
command: [ "sh","-c","cp -n preload/preload.sqlite3 /data/db.sqlite3; chown -R 999:999 /data; ls -la /data; sleep 10; exit 0" ]
|
||||
volumeMounts:
|
||||
- name: data
|
||||
mountPath: /data
|
||||
containers:
|
||||
- name: web
|
||||
image: git.baumann.gr/adebaumann/vui:0.938
|
||||
image: git.baumann.gr/adebaumann/vui:0.943
|
||||
imagePullPolicy: Always
|
||||
ports:
|
||||
- containerPort: 8000
|
||||
|
||||
Binary file not shown.
BIN
data/db.sqlite3
BIN
data/db.sqlite3
Binary file not shown.
@@ -2,6 +2,7 @@ from django.contrib import admin
|
||||
#from nested_inline.admin import NestedStackedInline, NestedModelAdmin
|
||||
from nested_admin import NestedStackedInline, NestedModelAdmin, NestedTabularInline
|
||||
from django import forms
|
||||
from django.utils.html import format_html
|
||||
from mptt.forms import TreeNodeMultipleChoiceField
|
||||
from mptt.admin import DraggableMPTTAdmin
|
||||
from adminsortable2.admin import SortableInlineAdminMixin, SortableAdminBase
|
||||
@@ -21,45 +22,75 @@ from referenzen.models import Referenz
|
||||
# 'frage': forms.Textarea(attrs={'rows': 1, 'cols': 100}),
|
||||
# }
|
||||
|
||||
class ChecklistenfragenInline(NestedTabularInline):
|
||||
class ChecklistenfragenInline(NestedStackedInline):
|
||||
model=Checklistenfrage
|
||||
extra=0
|
||||
fk_name="vorgabe"
|
||||
# form=ChecklistenForm
|
||||
classes = ['collapse']
|
||||
verbose_name_plural = "Checklistenfragen"
|
||||
fieldsets = (
|
||||
(None, {
|
||||
'fields': ('frage',),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
)
|
||||
|
||||
|
||||
class VorgabeKurztextInline(NestedTabularInline):
|
||||
class VorgabeKurztextInline(NestedStackedInline):
|
||||
model=VorgabeKurztext
|
||||
extra=0
|
||||
sortable_field_name = "order"
|
||||
show_change_link=True
|
||||
classes = ['collapse']
|
||||
#inline=inhalt
|
||||
verbose_name_plural = "Kurztext-Abschnitte"
|
||||
fieldsets = (
|
||||
(None, {
|
||||
'fields': ('abschnitttyp', 'inhalt', 'order'),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
)
|
||||
|
||||
class VorgabeLangtextInline(NestedTabularInline):
|
||||
class VorgabeLangtextInline(NestedStackedInline):
|
||||
model=VorgabeLangtext
|
||||
extra=0
|
||||
sortable_field_name = "order"
|
||||
show_change_link=True
|
||||
classes = ['collapse']
|
||||
#inline=inhalt
|
||||
verbose_name_plural = "Langtext-Abschnitte"
|
||||
fieldsets = (
|
||||
(None, {
|
||||
'fields': ('abschnitttyp', 'inhalt', 'order'),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
)
|
||||
|
||||
class GeltungsbereichInline(NestedTabularInline):
|
||||
class GeltungsbereichInline(NestedStackedInline):
|
||||
model=Geltungsbereich
|
||||
extra=0
|
||||
sortable_field_name = "order"
|
||||
show_change_link=True
|
||||
classes = ['collapse']
|
||||
classes = ['collapse']
|
||||
#inline=inhalt
|
||||
verbose_name_plural = "Geltungsbereich-Abschnitte"
|
||||
fieldsets = (
|
||||
(None, {
|
||||
'fields': ('abschnitttyp', 'inhalt', 'order'),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
)
|
||||
|
||||
class EinleitungInline(NestedTabularInline):
|
||||
model = Einleitung
|
||||
extra = 0
|
||||
sortable_field_name = "order"
|
||||
show_change_link = True
|
||||
classes = ['collapse']
|
||||
class EinleitungInline(NestedStackedInline):
|
||||
model = Einleitung
|
||||
extra = 0
|
||||
sortable_field_name = "order"
|
||||
show_change_link = True
|
||||
classes = ['collapse']
|
||||
verbose_name_plural = "Einleitungs-Abschnitte"
|
||||
fieldsets = (
|
||||
(None, {
|
||||
'fields': ('abschnitttyp', 'inhalt', 'order'),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
)
|
||||
|
||||
class VorgabeForm(forms.ModelForm):
|
||||
referenzen = TreeNodeMultipleChoiceField(queryset=Referenz.objects.all(), required=False)
|
||||
@@ -67,17 +98,31 @@ class VorgabeForm(forms.ModelForm):
|
||||
model = Vorgabe
|
||||
fields = '__all__'
|
||||
|
||||
class VorgabeInline(SortableInlineAdminMixin, NestedTabularInline): # or StackedInline for more vertical layout
|
||||
class VorgabeInline(SortableInlineAdminMixin, NestedStackedInline):
|
||||
model = Vorgabe
|
||||
form = VorgabeForm
|
||||
extra = 0
|
||||
sortable_field_name = "order" # Add this - make sure your Vorgabe model has an 'order' field
|
||||
#show_change_link = True
|
||||
inlines = [VorgabeKurztextInline,VorgabeLangtextInline,ChecklistenfragenInline]
|
||||
sortable_field_name = "order"
|
||||
show_change_link = False
|
||||
can_delete = False
|
||||
inlines = [VorgabeKurztextInline, VorgabeLangtextInline, ChecklistenfragenInline]
|
||||
autocomplete_fields = ['stichworte','referenzen','relevanz']
|
||||
#search_fields=['nummer','name']ModelAdmin.
|
||||
list_filter=['stichworte']
|
||||
#classes=["collapse"]
|
||||
# Remove collapse class so Vorgaben show by default
|
||||
|
||||
fieldsets = (
|
||||
('Grunddaten', {
|
||||
'fields': (('order', 'nummer'), ('thema', 'titel')),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
('Gültigkeit', {
|
||||
'fields': (('gueltigkeit_von', 'gueltigkeit_bis'),),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
('Verknüpfungen', {
|
||||
'fields': (('referenzen', 'stichworte', 'relevanz'),),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
)
|
||||
|
||||
class StichworterklaerungInline(NestedTabularInline):
|
||||
model=Stichworterklaerung
|
||||
@@ -88,9 +133,57 @@ class StichworterklaerungInline(NestedTabularInline):
|
||||
|
||||
@admin.register(Stichwort)
|
||||
class StichwortAdmin(NestedModelAdmin):
|
||||
list_display = ('stichwort', 'vorgaben_count')
|
||||
search_fields = ('stichwort',)
|
||||
ordering=('stichwort',)
|
||||
inlines=[StichworterklaerungInline]
|
||||
readonly_fields = ('vorgaben_list',)
|
||||
fieldsets = (
|
||||
(None, {
|
||||
'fields': ('stichwort', 'vorgaben_list')
|
||||
}),
|
||||
)
|
||||
|
||||
def vorgaben_count(self, obj):
|
||||
"""Count the number of Vorgaben that have this Stichwort"""
|
||||
count = obj.vorgabe_set.count()
|
||||
return f"{count} Vorgabe{'n' if count != 1 else ''}"
|
||||
vorgaben_count.short_description = "Anzahl Vorgaben"
|
||||
|
||||
def vorgaben_list(self, obj):
|
||||
"""Display list of Vorgaben that use this Stichwort"""
|
||||
vorgaben = obj.vorgabe_set.select_related('dokument', 'thema').order_by('dokument__nummer', 'nummer')
|
||||
vorgaben_list = list(vorgaben) # Evaluate queryset once
|
||||
count = len(vorgaben_list)
|
||||
|
||||
if count == 0:
|
||||
return format_html("<em>Keine Vorgaben gefunden</em><p><strong>Gesamt: 0 Vorgaben</strong></p>")
|
||||
|
||||
html = "<div style='max-height: 300px; overflow-y: auto;'>"
|
||||
html += "<table style='width: 100%; border-collapse: collapse;'>"
|
||||
html += "<thead><tr style='background-color: #f5f5f5;'>"
|
||||
html += "<th style='padding: 8px; border: 1px solid #ddd; text-align: left;'>Vorgabe</th>"
|
||||
html += "<th style='padding: 8px; border: 1px solid #ddd; text-align: left;'>Titel</th>"
|
||||
html += "<th style='padding: 8px; border: 1px solid #ddd; text-align: left;'>Dokument</th>"
|
||||
html += "</tr></thead>"
|
||||
html += "<tbody>"
|
||||
|
||||
for vorgabe in vorgaben_list:
|
||||
html += "<tr>"
|
||||
html += f"<td style='padding: 6px; border: 1px solid #ddd;'>{vorgabe.Vorgabennummer()}</td>"
|
||||
html += f"<td style='padding: 6px; border: 1px solid #ddd;'>{vorgabe.titel}</td>"
|
||||
html += f"<td style='padding: 6px; border: 1px solid #ddd;'>{vorgabe.dokument.nummer} – {vorgabe.dokument.name}</td>"
|
||||
html += "</tr>"
|
||||
|
||||
html += "</tbody></table>"
|
||||
html += f"</div><p><strong>Gesamt: {count} Vorgabe{'n' if count != 1 else ''}</strong></p>"
|
||||
|
||||
return format_html(html)
|
||||
vorgaben_list.short_description = "Zugeordnete Vorgaben"
|
||||
|
||||
def get_queryset(self, request):
|
||||
"""Optimize queryset with related data"""
|
||||
return super().get_queryset(request).prefetch_related('vorgabe_set')
|
||||
|
||||
@admin.register(Person)
|
||||
class PersonAdmin(admin.ModelAdmin):
|
||||
@@ -104,26 +197,102 @@ class PersonAdmin(admin.ModelAdmin):
|
||||
@admin.register(Dokument)
|
||||
class DokumentAdmin(SortableAdminBase, NestedModelAdmin):
|
||||
actions_on_top=True
|
||||
inlines = [EinleitungInline,GeltungsbereichInline,VorgabeInline]
|
||||
#filter_horizontal=['autoren','pruefende']
|
||||
list_display=['nummer','name','dokumententyp']
|
||||
inlines = [EinleitungInline, GeltungsbereichInline, VorgabeInline]
|
||||
filter_horizontal=['autoren','pruefende']
|
||||
list_display=['nummer','name','dokumententyp','gueltigkeit_von','gueltigkeit_bis','aktiv']
|
||||
search_fields=['nummer','name']
|
||||
list_filter=['dokumententyp','aktiv','gueltigkeit_von']
|
||||
|
||||
fieldsets = (
|
||||
('Grunddaten', {
|
||||
'fields': ('nummer', 'name', 'dokumententyp', 'aktiv'),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
('Verantwortlichkeiten', {
|
||||
'fields': ('autoren', 'pruefende'),
|
||||
'classes': ('wide', 'collapse'),
|
||||
}),
|
||||
('Gültigkeit & Metadaten', {
|
||||
'fields': ('gueltigkeit_von', 'gueltigkeit_bis', 'signatur_cso', 'anhaenge'),
|
||||
'classes': ('wide', 'collapse'),
|
||||
}),
|
||||
)
|
||||
|
||||
class Media:
|
||||
# js = ('admin/js/vorgabe_collapse.js',)
|
||||
js = ('admin/js/vorgabe_collapse.js',)
|
||||
css = {
|
||||
'all': ('admin/css/vorgabe_border.css',
|
||||
# 'admin/css/vorgabe_collapse.css',
|
||||
)
|
||||
'all': ('admin/css/vorgabe_border.css',)
|
||||
}
|
||||
|
||||
|
||||
#admin.site.register(Stichwort)
|
||||
|
||||
@admin.register(VorgabenTable)
|
||||
class VorgabenTableAdmin(admin.ModelAdmin):
|
||||
list_display = ['order', 'nummer', 'dokument', 'thema', 'titel', 'gueltigkeit_von', 'gueltigkeit_bis']
|
||||
list_display_links = ['dokument']
|
||||
list_editable = ['order', 'nummer', 'thema', 'titel', 'gueltigkeit_von', 'gueltigkeit_bis']
|
||||
list_filter = ['dokument', 'thema', 'gueltigkeit_von', 'gueltigkeit_bis']
|
||||
search_fields = ['nummer', 'titel', 'dokument__nummer', 'dokument__name']
|
||||
autocomplete_fields = ['dokument', 'thema', 'stichworte', 'referenzen', 'relevanz']
|
||||
ordering = ['order']
|
||||
list_per_page = 100
|
||||
|
||||
fieldsets = (
|
||||
('Grunddaten', {
|
||||
'fields': ('order', 'nummer', 'dokument', 'thema', 'titel')
|
||||
}),
|
||||
('Gültigkeit', {
|
||||
'fields': ('gueltigkeit_von', 'gueltigkeit_bis')
|
||||
}),
|
||||
('Verknüpfungen', {
|
||||
'fields': ('referenzen', 'stichworte', 'relevanz'),
|
||||
'classes': ('collapse',)
|
||||
}),
|
||||
)
|
||||
|
||||
@admin.register(Thema)
|
||||
class ThemaAdmin(admin.ModelAdmin):
|
||||
search_fields = ['name']
|
||||
ordering = ['name']
|
||||
|
||||
@admin.register(Vorgabe)
|
||||
class VorgabeAdmin(NestedModelAdmin):
|
||||
form = VorgabeForm
|
||||
list_display = ['vorgabe_nummer', 'titel', 'dokument', 'thema', 'gueltigkeit_von', 'gueltigkeit_bis']
|
||||
list_filter = ['dokument', 'thema', 'gueltigkeit_von', 'gueltigkeit_bis']
|
||||
search_fields = ['nummer', 'titel', 'dokument__nummer', 'dokument__name']
|
||||
autocomplete_fields = ['stichworte', 'referenzen', 'relevanz']
|
||||
ordering = ['dokument', 'order']
|
||||
|
||||
inlines = [
|
||||
VorgabeKurztextInline,
|
||||
VorgabeLangtextInline,
|
||||
ChecklistenfragenInline
|
||||
]
|
||||
|
||||
fieldsets = (
|
||||
('Grunddaten', {
|
||||
'fields': (('order', 'nummer'), ('dokument', 'thema'), 'titel'),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
('Gültigkeit', {
|
||||
'fields': (('gueltigkeit_von', 'gueltigkeit_bis'),),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
('Verknüpfungen', {
|
||||
'fields': (('referenzen', 'stichworte', 'relevanz'),),
|
||||
'classes': ('wide',),
|
||||
}),
|
||||
)
|
||||
|
||||
def vorgabe_nummer(self, obj):
|
||||
return obj.Vorgabennummer()
|
||||
vorgabe_nummer.short_description = 'Vorgabennummer'
|
||||
|
||||
admin.site.register(Checklistenfrage)
|
||||
admin.site.register(Dokumententyp)
|
||||
#admin.site.register(Person)
|
||||
admin.site.register(Thema)
|
||||
#admin.site.register(Referenz, DraggableM§PTTAdmin)
|
||||
admin.site.register(Vorgabe)
|
||||
|
||||
|
||||
#admin.site.register(Changelog)
|
||||
|
||||
174
dokumente/management/commands/export_json.py
Normal file
174
dokumente/management/commands/export_json.py
Normal file
@@ -0,0 +1,174 @@
|
||||
from django.core.management.base import BaseCommand
|
||||
from django.core.serializers.json import DjangoJSONEncoder
|
||||
import json
|
||||
from datetime import datetime
|
||||
from dokumente.models import Dokument, Vorgabe, VorgabeKurztext, VorgabeLangtext, Checklistenfrage
|
||||
|
||||
|
||||
class Command(BaseCommand):
|
||||
help = 'Export all dokumente as JSON using R0066.json format as reference'
|
||||
|
||||
def add_arguments(self, parser):
|
||||
parser.add_argument(
|
||||
'--output',
|
||||
type=str,
|
||||
help='Output file path (default: stdout)',
|
||||
)
|
||||
|
||||
def handle(self, *args, **options):
|
||||
# Get all active documents
|
||||
dokumente = Dokument.objects.filter(aktiv=True).prefetch_related(
|
||||
'autoren', 'pruefende', 'vorgaben__thema',
|
||||
'vorgaben__referenzen', 'vorgaben__stichworte',
|
||||
'vorgaben__checklistenfragen', 'vorgaben__vorgabekurztext_set',
|
||||
'vorgaben__vorgabelangtext_set', 'geltungsbereich_set',
|
||||
'einleitung_set', 'changelog__autoren'
|
||||
).order_by('nummer')
|
||||
|
||||
result = {
|
||||
"Vorgabendokument": {
|
||||
"Typ": "Standard IT-Sicherheit",
|
||||
"Nummer": "", # Will be set per document
|
||||
"Name": "", # Will be set per document
|
||||
"Autoren": [], # Will be set per document
|
||||
"Pruefende": [], # Will be set per document
|
||||
"Geltungsbereich": {
|
||||
"Abschnitt": []
|
||||
},
|
||||
"Ziel": "",
|
||||
"Grundlagen": "",
|
||||
"Changelog": [],
|
||||
"Anhänge": [],
|
||||
"Verantwortlich": "Information Security Management BIT",
|
||||
"Klassifizierung": None,
|
||||
"Glossar": {},
|
||||
"Vorgaben": []
|
||||
}
|
||||
}
|
||||
|
||||
output_data = []
|
||||
|
||||
for dokument in dokumente:
|
||||
# Build document structure
|
||||
doc_data = {
|
||||
"Typ": dokument.dokumententyp.name if dokument.dokumententyp else "",
|
||||
"Nummer": dokument.nummer,
|
||||
"Name": dokument.name,
|
||||
"Autoren": [autor.name for autor in dokument.autoren.all()],
|
||||
"Pruefende": [pruefender.name for pruefender in dokument.pruefende.all()],
|
||||
"Gueltigkeit": {
|
||||
"Von": dokument.gueltigkeit_von.strftime("%Y-%m-%d") if dokument.gueltigkeit_von else "",
|
||||
"Bis": dokument.gueltigkeit_bis.strftime("%Y-%m-%d") if dokument.gueltigkeit_bis else None
|
||||
},
|
||||
"SignaturCSO": dokument.signatur_cso,
|
||||
"Geltungsbereich": {},
|
||||
"Einleitung": {},
|
||||
"Ziel": "",
|
||||
"Grundlagen": "",
|
||||
"Changelog": [],
|
||||
"Anhänge": dokument.anhaenge,
|
||||
"Verantwortlich": "Information Security Management BIT",
|
||||
"Klassifizierung": None,
|
||||
"Glossar": {},
|
||||
"Vorgaben": []
|
||||
}
|
||||
|
||||
# Process Geltungsbereich sections
|
||||
geltungsbereich_sections = []
|
||||
for gb in dokument.geltungsbereich_set.all().order_by('order'):
|
||||
geltungsbereich_sections.append({
|
||||
"typ": gb.abschnitttyp.abschnitttyp if gb.abschnitttyp else "text",
|
||||
"inhalt": gb.inhalt
|
||||
})
|
||||
|
||||
if geltungsbereich_sections:
|
||||
doc_data["Geltungsbereich"] = {
|
||||
"Abschnitt": geltungsbereich_sections
|
||||
}
|
||||
|
||||
# Process Einleitung sections
|
||||
einleitung_sections = []
|
||||
for ei in dokument.einleitung_set.all().order_by('order'):
|
||||
einleitung_sections.append({
|
||||
"typ": ei.abschnitttyp.abschnitttyp if ei.abschnitttyp else "text",
|
||||
"inhalt": ei.inhalt
|
||||
})
|
||||
|
||||
if einleitung_sections:
|
||||
doc_data["Einleitung"] = {
|
||||
"Abschnitt": einleitung_sections
|
||||
}
|
||||
|
||||
# Process Changelog entries
|
||||
changelog_entries = []
|
||||
for cl in dokument.changelog.all().order_by('-datum'):
|
||||
changelog_entries.append({
|
||||
"Datum": cl.datum.strftime("%Y-%m-%d"),
|
||||
"Autoren": [autor.name for autor in cl.autoren.all()],
|
||||
"Aenderung": cl.aenderung
|
||||
})
|
||||
|
||||
doc_data["Changelog"] = changelog_entries
|
||||
|
||||
# Process Vorgaben for this document
|
||||
vorgaben = dokument.vorgaben.all().order_by('order')
|
||||
|
||||
for vorgabe in vorgaben:
|
||||
# Get Kurztext and Langtext
|
||||
kurztext_sections = []
|
||||
for kt in vorgabe.vorgabekurztext_set.all().order_by('order'):
|
||||
kurztext_sections.append({
|
||||
"typ": kt.abschnitttyp.abschnitttyp if kt.abschnitttyp else "text",
|
||||
"inhalt": kt.inhalt
|
||||
})
|
||||
|
||||
langtext_sections = []
|
||||
for lt in vorgabe.vorgabelangtext_set.all().order_by('order'):
|
||||
langtext_sections.append({
|
||||
"typ": lt.abschnitttyp.abschnitttyp if lt.abschnitttyp else "text",
|
||||
"inhalt": lt.inhalt
|
||||
})
|
||||
|
||||
# Build text structures following Langtext pattern
|
||||
kurztext = {
|
||||
"Abschnitt": kurztext_sections if kurztext_sections else []
|
||||
} if kurztext_sections else {}
|
||||
langtext = {
|
||||
"Abschnitt": langtext_sections if langtext_sections else []
|
||||
} if langtext_sections else {}
|
||||
|
||||
# Get references and keywords
|
||||
referenzen = [f"{ref.name_nummer}: {ref.name_text}" if ref.name_text else ref.name_nummer for ref in vorgabe.referenzen.all()]
|
||||
stichworte = [stw.stichwort for stw in vorgabe.stichworte.all()]
|
||||
|
||||
# Get checklist questions
|
||||
checklistenfragen = [cf.frage for cf in vorgabe.checklistenfragen.all()]
|
||||
|
||||
vorgabe_data = {
|
||||
"Nummer": str(vorgabe.nummer),
|
||||
"Titel": vorgabe.titel,
|
||||
"Thema": vorgabe.thema.name if vorgabe.thema else "",
|
||||
"Kurztext": kurztext,
|
||||
"Langtext": langtext,
|
||||
"Referenz": referenzen,
|
||||
"Gueltigkeit": {
|
||||
"Von": vorgabe.gueltigkeit_von.strftime("%Y-%m-%d") if vorgabe.gueltigkeit_von else "",
|
||||
"Bis": vorgabe.gueltigkeit_bis.strftime("%Y-%m-%d") if vorgabe.gueltigkeit_bis else None
|
||||
},
|
||||
"Checklistenfragen": checklistenfragen,
|
||||
"Stichworte": stichworte
|
||||
}
|
||||
|
||||
doc_data["Vorgaben"].append(vorgabe_data)
|
||||
|
||||
output_data.append(doc_data)
|
||||
|
||||
# Output the data
|
||||
json_output = json.dumps(output_data, cls=DjangoJSONEncoder, indent=2, ensure_ascii=False)
|
||||
|
||||
if options['output']:
|
||||
with open(options['output'], 'w', encoding='utf-8') as f:
|
||||
f.write(json_output)
|
||||
self.stdout.write(self.style.SUCCESS(f'JSON exported to {options["output"]}'))
|
||||
else:
|
||||
self.stdout.write(json_output)
|
||||
70
dokumente/management/commands/sanity_check_vorgaben.py
Normal file
70
dokumente/management/commands/sanity_check_vorgaben.py
Normal file
@@ -0,0 +1,70 @@
|
||||
from django.core.management.base import BaseCommand
|
||||
from django.db import transaction
|
||||
from dokumente.models import Vorgabe
|
||||
import datetime
|
||||
|
||||
|
||||
class Command(BaseCommand):
|
||||
help = 'Run sanity checks on Vorgaben to detect conflicts'
|
||||
|
||||
def add_arguments(self, parser):
|
||||
parser.add_argument(
|
||||
'--fix',
|
||||
action='store_true',
|
||||
help='Attempt to fix conflicts (not implemented yet)',
|
||||
)
|
||||
parser.add_argument(
|
||||
'--verbose',
|
||||
action='store_true',
|
||||
help='Show detailed output',
|
||||
)
|
||||
|
||||
def handle(self, *args, **options):
|
||||
self.verbose = options['verbose']
|
||||
|
||||
self.stdout.write(self.style.SUCCESS('Starting Vorgaben sanity check...'))
|
||||
|
||||
# Run the sanity check
|
||||
conflicts = Vorgabe.sanity_check_vorgaben()
|
||||
|
||||
if not conflicts:
|
||||
self.stdout.write(self.style.SUCCESS('✓ No conflicts found in Vorgaben'))
|
||||
return
|
||||
|
||||
self.stdout.write(
|
||||
self.style.WARNING(f'Found {len(conflicts)} conflicts:')
|
||||
)
|
||||
|
||||
for i, conflict in enumerate(conflicts, 1):
|
||||
self._display_conflict(i, conflict)
|
||||
|
||||
if options['fix']:
|
||||
self.stdout.write(self.style.ERROR('Auto-fix not implemented yet'))
|
||||
|
||||
def _display_conflict(self, index, conflict):
|
||||
"""Display a single conflict"""
|
||||
v1 = conflict['vorgabe1']
|
||||
v2 = conflict['vorgabe2']
|
||||
|
||||
self.stdout.write(f"\n{index}. {conflict['message']}")
|
||||
|
||||
if self.verbose:
|
||||
self.stdout.write(f" Vorgabe 1: {v1.Vorgabennummer()}")
|
||||
self.stdout.write(f" Valid from: {v1.gueltigkeit_von} to {v1.gueltigkeit_bis or 'unlimited'}")
|
||||
self.stdout.write(f" Title: {v1.titel}")
|
||||
|
||||
self.stdout.write(f" Vorgabe 2: {v2.Vorgabennummer()}")
|
||||
self.stdout.write(f" Valid from: {v2.gueltigkeit_von} to {v2.gueltigkeit_bis or 'unlimited'}")
|
||||
self.stdout.write(f" Title: {v2.titel}")
|
||||
|
||||
# Show the overlapping period
|
||||
overlap_start = max(v1.gueltigkeit_von, v2.gueltigkeit_von)
|
||||
overlap_end = min(
|
||||
v1.gueltigkeit_bis or datetime.date.max,
|
||||
v2.gueltigkeit_bis or datetime.date.max
|
||||
)
|
||||
|
||||
if overlap_end != datetime.date.max:
|
||||
self.stdout.write(f" Overlap: {overlap_start} to {overlap_end}")
|
||||
else:
|
||||
self.stdout.write(f" Overlap starts: {overlap_start} (no end)")
|
||||
@@ -60,7 +60,7 @@ class Vorgabe(models.Model):
|
||||
order = models.IntegerField()
|
||||
nummer = models.IntegerField()
|
||||
dokument = models.ForeignKey(Dokument, on_delete=models.CASCADE, related_name='vorgaben')
|
||||
thema = models.ForeignKey(Thema, on_delete=models.PROTECT)
|
||||
thema = models.ForeignKey(Thema, on_delete=models.PROTECT, blank=False)
|
||||
titel = models.CharField(max_length=255)
|
||||
referenzen = models.ManyToManyField(Referenz, blank=True)
|
||||
gueltigkeit_von = models.DateField()
|
||||
@@ -78,7 +78,7 @@ class Vorgabe(models.Model):
|
||||
if not self.gueltigkeit_bis:
|
||||
return "active"
|
||||
|
||||
if self.gueltigkeit_bis > check_date:
|
||||
if self.gueltigkeit_bis >= check_date:
|
||||
return "active"
|
||||
|
||||
return "expired" if not verbose else "Ist seit dem "+self.gueltigkeit_bis.strftime('%d.%m.%Y')+" nicht mehr in Kraft."
|
||||
@@ -86,6 +86,123 @@ class Vorgabe(models.Model):
|
||||
def __str__(self):
|
||||
return f"{self.Vorgabennummer()}: {self.titel}"
|
||||
|
||||
@staticmethod
|
||||
def sanity_check_vorgaben():
|
||||
"""
|
||||
Sanity check for Vorgaben:
|
||||
If there are two Vorgaben with the same number, Thema and Dokument,
|
||||
their valid_from and valid_to date ranges shouldn't intersect.
|
||||
|
||||
Returns:
|
||||
list: List of dictionaries containing conflicts found
|
||||
"""
|
||||
conflicts = []
|
||||
|
||||
# Group Vorgaben by dokument, thema, and nummer
|
||||
from django.db.models import Count
|
||||
from itertools import combinations
|
||||
|
||||
# Find Vorgaben with same dokument, thema, and nummer
|
||||
duplicate_groups = (
|
||||
Vorgabe.objects.values('dokument', 'thema', 'nummer')
|
||||
.annotate(count=Count('id'))
|
||||
.filter(count__gt=1)
|
||||
)
|
||||
|
||||
for group in duplicate_groups:
|
||||
# Get all Vorgaben in this group
|
||||
vorgaben = Vorgabe.objects.filter(
|
||||
dokument=group['dokument'],
|
||||
thema=group['thema'],
|
||||
nummer=group['nummer']
|
||||
)
|
||||
|
||||
# Check all pairs for date range intersections
|
||||
for vorgabe1, vorgabe2 in combinations(vorgaben, 2):
|
||||
if Vorgabe._date_ranges_intersect(
|
||||
vorgabe1.gueltigkeit_von, vorgabe1.gueltigkeit_bis,
|
||||
vorgabe2.gueltigkeit_von, vorgabe2.gueltigkeit_bis
|
||||
):
|
||||
conflicts.append({
|
||||
'vorgabe1': vorgabe1,
|
||||
'vorgabe2': vorgabe2,
|
||||
'conflict_type': 'date_range_intersection',
|
||||
'message': f"Vorgaben {vorgabe1.Vorgabennummer()} and {vorgabe2.Vorgabennummer()} "
|
||||
f"überschneiden sich in der Geltungsdauer"
|
||||
})
|
||||
|
||||
return conflicts
|
||||
|
||||
def clean(self):
|
||||
"""
|
||||
Validate the Vorgabe before saving.
|
||||
"""
|
||||
from django.core.exceptions import ValidationError
|
||||
|
||||
# Check for conflicts with existing Vorgaben
|
||||
conflicts = self.find_conflicts()
|
||||
if conflicts:
|
||||
conflict_messages = [c['message'] for c in conflicts]
|
||||
raise ValidationError({
|
||||
'__all__': conflict_messages
|
||||
})
|
||||
|
||||
def find_conflicts(self):
|
||||
"""
|
||||
Find conflicts with existing Vorgaben.
|
||||
|
||||
Returns:
|
||||
list: List of conflict dictionaries
|
||||
"""
|
||||
conflicts = []
|
||||
|
||||
# Find Vorgaben with same dokument, thema, and nummer (excluding self)
|
||||
existing_vorgaben = Vorgabe.objects.filter(
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
nummer=self.nummer
|
||||
).exclude(pk=self.pk)
|
||||
|
||||
for other_vorgabe in existing_vorgaben:
|
||||
if self._date_ranges_intersect(
|
||||
self.gueltigkeit_von, self.gueltigkeit_bis,
|
||||
other_vorgabe.gueltigkeit_von, other_vorgabe.gueltigkeit_bis
|
||||
):
|
||||
conflicts.append({
|
||||
'vorgabe1': self,
|
||||
'vorgabe2': other_vorgabe,
|
||||
'conflict_type': 'date_range_intersection',
|
||||
'message': f"Vorgabe {self.Vorgabennummer()} in Konflikt mit "
|
||||
f"bestehender {other_vorgabe.Vorgabennummer()} "
|
||||
f" - Geltungsdauer übeschneidet sich"
|
||||
})
|
||||
|
||||
return conflicts
|
||||
|
||||
@staticmethod
|
||||
def _date_ranges_intersect(start1, end1, start2, end2):
|
||||
"""
|
||||
Check if two date ranges intersect.
|
||||
None end date means open-ended range.
|
||||
|
||||
Args:
|
||||
start1, start2: Start dates
|
||||
end1, end2: End dates (can be None for open-ended)
|
||||
|
||||
Returns:
|
||||
bool: True if ranges intersect
|
||||
"""
|
||||
# If either start date is None, treat it as invalid case
|
||||
if not start1 or not start2:
|
||||
return False
|
||||
|
||||
# If end date is None, treat it as far future
|
||||
end1 = end1 or datetime.date.max
|
||||
end2 = end2 or datetime.date.max
|
||||
|
||||
# Ranges intersect if start1 <= end2 and start2 <= end1
|
||||
return start1 <= end2 and start2 <= end1
|
||||
|
||||
class Meta:
|
||||
verbose_name_plural="Vorgaben"
|
||||
ordering = ['order']
|
||||
@@ -125,6 +242,12 @@ class Checklistenfrage(models.Model):
|
||||
verbose_name_plural="Fragen für Checkliste"
|
||||
verbose_name="Frage für Checkliste"
|
||||
|
||||
class VorgabenTable(Vorgabe):
|
||||
class Meta:
|
||||
proxy = True
|
||||
verbose_name = "Vorgabe (Tabellenansicht)"
|
||||
verbose_name_plural = "Vorgaben (Tabellenansicht)"
|
||||
|
||||
class Changelog(models.Model):
|
||||
dokument = models.ForeignKey(Dokument, on_delete=models.CASCADE, related_name='changelog')
|
||||
autoren = models.ManyToManyField(Person)
|
||||
|
||||
151
dokumente/templates/standards/incomplete_vorgaben.html
Normal file
151
dokumente/templates/standards/incomplete_vorgaben.html
Normal file
@@ -0,0 +1,151 @@
|
||||
{% extends "base.html" %}
|
||||
{% block content %}
|
||||
<h1 class="mb-4">Unvollständige Vorgaben</h1>
|
||||
|
||||
{% if vorgaben_data %}
|
||||
<div class="table-responsive">
|
||||
<table class="table table-striped table-hover">
|
||||
<thead class="table-dark">
|
||||
<tr>
|
||||
<th>Vorgabe</th>
|
||||
<th class="text-center">Referenzen</th>
|
||||
<th class="text-center">Stichworte</th>
|
||||
<th class="text-center">Text</th>
|
||||
<th class="text-center">Checklistenfragen</th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody>
|
||||
{% for item in vorgaben_data %}
|
||||
<tr>
|
||||
<td>
|
||||
<a href="/autorenumgebung/dokumente/vorgabe/{{ item.vorgabe.id }}/change/"
|
||||
class="text-decoration-none" target="_blank">
|
||||
<strong>{{ item.vorgabe.Vorgabennummer }}</strong><br>
|
||||
<small class="text-muted">{{ item.vorgabe.titel }}</small><br>
|
||||
<small class="text-muted">{{ item.vorgabe.dokument.nummer }} – {{ item.vorgabe.dokument.name }}</small>
|
||||
</a>
|
||||
</td>
|
||||
<td class="text-center align-middle">
|
||||
{% if item.has_references %}
|
||||
<span class="text-success fs-4">✓</span>
|
||||
{% else %}
|
||||
<span class="text-danger fs-4">✗</span>
|
||||
{% endif %}
|
||||
</td>
|
||||
<td class="text-center align-middle">
|
||||
{% if item.has_stichworte %}
|
||||
<span class="text-success fs-4">✓</span>
|
||||
{% else %}
|
||||
<span class="text-danger fs-4">✗</span>
|
||||
{% endif %}
|
||||
</td>
|
||||
<td class="text-center align-middle">
|
||||
{% if item.has_text %}
|
||||
<span class="text-success fs-4">✓</span>
|
||||
{% else %}
|
||||
<span class="text-danger fs-4">✗</span>
|
||||
{% endif %}
|
||||
</td>
|
||||
<td class="text-center align-middle">
|
||||
{% if item.has_checklistenfragen %}
|
||||
<span class="text-success fs-4">✓</span>
|
||||
{% else %}
|
||||
<span class="text-danger fs-4">✗</span>
|
||||
{% endif %}
|
||||
</td>
|
||||
</tr>
|
||||
{% endfor %}
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
|
||||
<!-- Summary -->
|
||||
<div class="row mt-4">
|
||||
<div class="col-12">
|
||||
<div class="card">
|
||||
<div class="card-header">
|
||||
<h5 class="mb-0">Zusammenfassung</h5>
|
||||
</div>
|
||||
<div class="card-body">
|
||||
<div class="row text-center">
|
||||
<div class="col-md-3">
|
||||
<div class="p-3">
|
||||
<h4 class="text-danger" id="no-references-count">0</h4>
|
||||
<p class="mb-0">Ohne Referenzen</p>
|
||||
</div>
|
||||
</div>
|
||||
<div class="col-md-3">
|
||||
<div class="p-3">
|
||||
<h4 class="text-danger" id="no-stichworte-count">0</h4>
|
||||
<p class="mb-0">Ohne Stichworte</p>
|
||||
</div>
|
||||
</div>
|
||||
<div class="col-md-3">
|
||||
<div class="p-3">
|
||||
<h4 class="text-danger" id="no-text-count">0</h4>
|
||||
<p class="mb-0">Ohne Text</p>
|
||||
</div>
|
||||
</div>
|
||||
<div class="col-md-3">
|
||||
<div class="p-3">
|
||||
<h4 class="text-danger" id="no-checklistenfragen-count">0</h4>
|
||||
<p class="mb-0">Ohne Checklistenfragen</p>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="row mt-3">
|
||||
<div class="col-12 text-center">
|
||||
<h4 class="text-primary">Gesamt: {{ vorgaben_data|length }} unvollständige Vorgaben</h4>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
{% else %}
|
||||
<div class="alert alert-success" role="alert">
|
||||
<h4 class="alert-heading">
|
||||
<i class="fas fa-check-circle"></i> Alle Vorgaben sind vollständig!
|
||||
</h4>
|
||||
<p>Alle Vorgaben haben Referenzen, Stichworte, Text und Checklistenfragen.</p>
|
||||
<hr>
|
||||
<p class="mb-0">
|
||||
<a href="{% url 'standard_list' %}" class="btn btn-primary">
|
||||
<i class="fas fa-list"></i> Zurück zur Übersicht
|
||||
</a>
|
||||
</p>
|
||||
</div>
|
||||
{% endif %}
|
||||
|
||||
<div class="mt-3">
|
||||
<a href="{% url 'standard_list' %}" class="btn btn-secondary">
|
||||
<i class="fas fa-arrow-left"></i> Zurück zur Übersicht
|
||||
</a>
|
||||
</div>
|
||||
|
||||
<script>
|
||||
// Update summary counts
|
||||
document.addEventListener('DOMContentLoaded', function() {
|
||||
let noReferences = 0;
|
||||
let noStichworte = 0;
|
||||
let noText = 0;
|
||||
let noChecklistenfragen = 0;
|
||||
|
||||
const rows = document.querySelectorAll('tbody tr');
|
||||
rows.forEach(function(row) {
|
||||
const cells = row.querySelectorAll('td');
|
||||
if (cells.length >= 5) {
|
||||
if (cells[1].textContent.trim() === '✗') noReferences++;
|
||||
if (cells[2].textContent.trim() === '✗') noStichworte++;
|
||||
if (cells[3].textContent.trim() === '✗') noText++;
|
||||
if (cells[4].textContent.trim() === '✗') noChecklistenfragen++;
|
||||
}
|
||||
});
|
||||
|
||||
document.getElementById('no-references-count').textContent = noReferences;
|
||||
document.getElementById('no-stichworte-count').textContent = noStichworte;
|
||||
document.getElementById('no-text-count').textContent = noText;
|
||||
document.getElementById('no-checklistenfragen-count').textContent = noChecklistenfragen;
|
||||
});
|
||||
</script>
|
||||
{% endblock %}
|
||||
@@ -9,6 +9,7 @@
|
||||
<p><strong>Autoren:</strong> {{ standard.autoren.all|join:", " }}</p>
|
||||
<p><strong>Prüfende:</strong> {{ standard.pruefende.all|join:", " }}</p>
|
||||
<p><strong>Gültigkeit:</strong> {{ standard.gueltigkeit_von }} bis {{ standard.gueltigkeit_bis|default_if_none:"auf weiteres" }}</p>
|
||||
<p><a href="{% url 'standard_json' standard.nummer %}" class="button" download="{{ standard.nummer }}.json">JSON herunterladen</a></p>
|
||||
|
||||
<!-- Start Einleitung -->
|
||||
{% if standard.einleitung_html %}
|
||||
|
||||
@@ -1,11 +1,15 @@
|
||||
from django.test import TestCase, Client
|
||||
from django.urls import reverse
|
||||
from django.core.management import call_command
|
||||
from django.contrib.auth.models import User
|
||||
from datetime import date, timedelta
|
||||
from io import StringIO
|
||||
from .models import (
|
||||
Dokumententyp, Person, Thema, Dokument, Vorgabe,
|
||||
VorgabeLangtext, VorgabeKurztext, Geltungsbereich,
|
||||
Einleitung, Checklistenfrage, Changelog
|
||||
)
|
||||
from .utils import check_vorgabe_conflicts, date_ranges_intersect, format_conflict_report
|
||||
from abschnitte.models import AbschnittTyp
|
||||
from referenzen.models import Referenz
|
||||
from stichworte.models import Stichwort
|
||||
@@ -513,3 +517,621 @@ class URLPatternsTest(TestCase):
|
||||
"""Test that standard_history URL resolves correctly"""
|
||||
url = reverse('standard_history', kwargs={'nummer': 'TEST-001'})
|
||||
self.assertEqual(url, '/dokumente/TEST-001/history/')
|
||||
|
||||
|
||||
class VorgabeSanityCheckTest(TestCase):
|
||||
"""Test cases for Vorgabe sanity check functionality"""
|
||||
|
||||
def setUp(self):
|
||||
"""Set up test data for sanity check tests"""
|
||||
self.dokumententyp = Dokumententyp.objects.create(
|
||||
name="Standard IT-Sicherheit",
|
||||
verantwortliche_ve="SR-SUR-SEC"
|
||||
)
|
||||
self.dokument = Dokument.objects.create(
|
||||
nummer="R0066",
|
||||
dokumententyp=self.dokumententyp,
|
||||
name="IT Security Standard",
|
||||
aktiv=True
|
||||
)
|
||||
self.thema = Thema.objects.create(name="Organisation")
|
||||
self.base_date = date(2023, 1, 1)
|
||||
|
||||
# Create non-conflicting Vorgaben
|
||||
self.vorgabe1 = Vorgabe.objects.create(
|
||||
order=1,
|
||||
nummer=1,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="First Vorgabe",
|
||||
gueltigkeit_von=self.base_date,
|
||||
gueltigkeit_bis=date(2023, 12, 31)
|
||||
)
|
||||
|
||||
self.vorgabe2 = Vorgabe.objects.create(
|
||||
order=2,
|
||||
nummer=2,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Second Vorgabe",
|
||||
gueltigkeit_von=self.base_date,
|
||||
gueltigkeit_bis=date(2023, 12, 31)
|
||||
)
|
||||
|
||||
def test_date_ranges_intersect_no_overlap(self):
|
||||
"""Test date_ranges_intersect with non-overlapping ranges"""
|
||||
# Range 1: 2023-01-01 to 2023-06-30
|
||||
# Range 2: 2023-07-01 to 2023-12-31
|
||||
result = date_ranges_intersect(
|
||||
date(2023, 1, 1), date(2023, 6, 30),
|
||||
date(2023, 7, 1), date(2023, 12, 31)
|
||||
)
|
||||
self.assertFalse(result)
|
||||
|
||||
def test_date_ranges_intersect_with_overlap(self):
|
||||
"""Test date_ranges_intersect with overlapping ranges"""
|
||||
# Range 1: 2023-01-01 to 2023-06-30
|
||||
# Range 2: 2023-06-01 to 2023-12-31 (overlaps in June)
|
||||
result = date_ranges_intersect(
|
||||
date(2023, 1, 1), date(2023, 6, 30),
|
||||
date(2023, 6, 1), date(2023, 12, 31)
|
||||
)
|
||||
self.assertTrue(result)
|
||||
|
||||
def test_date_ranges_intersect_with_none_end_date(self):
|
||||
"""Test date_ranges_intersect with None end date (open-ended)"""
|
||||
# Range 1: 2023-01-01 to None (open-ended)
|
||||
# Range 2: 2023-06-01 to 2023-12-31
|
||||
result = date_ranges_intersect(
|
||||
date(2023, 1, 1), None,
|
||||
date(2023, 6, 1), date(2023, 12, 31)
|
||||
)
|
||||
self.assertTrue(result)
|
||||
|
||||
def test_date_ranges_intersect_both_none_end_dates(self):
|
||||
"""Test date_ranges_intersect with both None end dates"""
|
||||
# Both ranges are open-ended
|
||||
result = date_ranges_intersect(
|
||||
date(2023, 1, 1), None,
|
||||
date(2023, 6, 1), None
|
||||
)
|
||||
self.assertTrue(result)
|
||||
|
||||
def test_date_ranges_intersect_identical_ranges(self):
|
||||
"""Test date_ranges_intersect with identical ranges"""
|
||||
result = date_ranges_intersect(
|
||||
date(2023, 1, 1), date(2023, 12, 31),
|
||||
date(2023, 1, 1), date(2023, 12, 31)
|
||||
)
|
||||
self.assertTrue(result)
|
||||
|
||||
def test_sanity_check_vorgaben_no_conflicts(self):
|
||||
"""Test sanity_check_vorgaben with no conflicts"""
|
||||
conflicts = Vorgabe.sanity_check_vorgaben()
|
||||
self.assertEqual(len(conflicts), 0)
|
||||
|
||||
def test_sanity_check_vorgaben_with_conflicts(self):
|
||||
"""Test sanity_check_vorgaben with conflicting Vorgaben"""
|
||||
# Create a conflicting Vorgabe (same nummer, thema, dokument with overlapping dates)
|
||||
conflicting_vorgabe = Vorgabe.objects.create(
|
||||
order=3,
|
||||
nummer=1, # Same as vorgabe1
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Conflicting Vorgabe",
|
||||
gueltigkeit_von=date(2023, 6, 1), # Overlaps with vorgabe1
|
||||
gueltigkeit_bis=date(2023, 8, 31)
|
||||
)
|
||||
|
||||
conflicts = Vorgabe.sanity_check_vorgaben()
|
||||
self.assertEqual(len(conflicts), 1)
|
||||
|
||||
conflict = conflicts[0]
|
||||
self.assertEqual(conflict['conflict_type'], 'date_range_intersection')
|
||||
self.assertIn('R0066.O.1', conflict['message'])
|
||||
self.assertIn('überschneiden sich in der Geltungsdauer', conflict['message'])
|
||||
self.assertEqual(conflict['vorgabe1'], self.vorgabe1)
|
||||
self.assertEqual(conflict['vorgabe2'], conflicting_vorgabe)
|
||||
|
||||
def test_sanity_check_vorgaben_multiple_conflicts(self):
|
||||
"""Test sanity_check_vorgaben with multiple conflict groups"""
|
||||
# Create first conflict group
|
||||
conflicting_vorgabe1 = Vorgabe.objects.create(
|
||||
order=3,
|
||||
nummer=1, # Same as vorgabe1
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Conflicting Vorgabe 1",
|
||||
gueltigkeit_von=date(2023, 6, 1),
|
||||
gueltigkeit_bis=date(2023, 8, 31)
|
||||
)
|
||||
|
||||
# Create second conflict group with different nummer
|
||||
conflicting_vorgabe2 = Vorgabe.objects.create(
|
||||
order=4,
|
||||
nummer=2, # Same as vorgabe2
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Conflicting Vorgabe 2",
|
||||
gueltigkeit_von=date(2023, 6, 1),
|
||||
gueltigkeit_bis=date(2023, 8, 31)
|
||||
)
|
||||
|
||||
conflicts = Vorgabe.sanity_check_vorgaben()
|
||||
self.assertEqual(len(conflicts), 2)
|
||||
|
||||
# Check that we have conflicts for both nummer 1 and nummer 2
|
||||
conflict_messages = [c['message'] for c in conflicts]
|
||||
self.assertTrue(any('R0066.O.1' in msg for msg in conflict_messages))
|
||||
self.assertTrue(any('R0066.O.2' in msg for msg in conflict_messages))
|
||||
|
||||
def test_find_conflicts_no_conflicts(self):
|
||||
"""Test find_conflicts method on Vorgabe with no conflicts"""
|
||||
conflicts = self.vorgabe1.find_conflicts()
|
||||
self.assertEqual(len(conflicts), 0)
|
||||
|
||||
def test_find_conflicts_with_conflicts(self):
|
||||
"""Test find_conflicts method on Vorgabe with conflicts"""
|
||||
# Create a conflicting Vorgabe
|
||||
conflicting_vorgabe = Vorgabe.objects.create(
|
||||
order=3,
|
||||
nummer=1, # Same as vorgabe1
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Conflicting Vorgabe",
|
||||
gueltigkeit_von=date(2023, 6, 1), # Overlaps
|
||||
gueltigkeit_bis=date(2023, 8, 31)
|
||||
)
|
||||
|
||||
conflicts = self.vorgabe1.find_conflicts()
|
||||
self.assertEqual(len(conflicts), 1)
|
||||
conflict = conflicts[0]
|
||||
self.assertEqual(conflict['vorgabe1'], self.vorgabe1)
|
||||
self.assertEqual(conflict['vorgabe2'], conflicting_vorgabe)
|
||||
|
||||
def test_vorgabe_clean_no_conflicts(self):
|
||||
"""Test Vorgabe.clean() with no conflicts"""
|
||||
try:
|
||||
self.vorgabe1.clean()
|
||||
except Exception as e:
|
||||
self.fail(f"clean() raised {e} unexpectedly!")
|
||||
|
||||
def test_vorgabe_clean_with_conflicts(self):
|
||||
"""Test Vorgabe.clean() with conflicts raises ValidationError"""
|
||||
# Create a conflicting Vorgabe
|
||||
conflicting_vorgabe = Vorgabe(
|
||||
order=3,
|
||||
nummer=1, # Same as vorgabe1
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Conflicting Vorgabe",
|
||||
gueltigkeit_von=date(2023, 6, 1), # Overlaps
|
||||
gueltigkeit_bis=date(2023, 8, 31)
|
||||
)
|
||||
|
||||
with self.assertRaises(Exception) as context:
|
||||
conflicting_vorgabe.clean()
|
||||
|
||||
self.assertIn('Konflikt mit bestehender', str(context.exception))
|
||||
self.assertIn('Geltungsdauer übeschneidet sich', str(context.exception))
|
||||
|
||||
def test_check_vorgabe_conflicts_utility(self):
|
||||
"""Test check_vorgabe_conflicts utility function"""
|
||||
# Initially no conflicts
|
||||
conflicts = check_vorgabe_conflicts()
|
||||
self.assertEqual(len(conflicts), 0)
|
||||
|
||||
# Create a conflicting Vorgabe
|
||||
conflicting_vorgabe = Vorgabe.objects.create(
|
||||
order=3,
|
||||
nummer=1, # Same as vorgabe1
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Conflicting Vorgabe",
|
||||
gueltigkeit_von=date(2023, 6, 1), # Overlaps
|
||||
gueltigkeit_bis=date(2023, 8, 31)
|
||||
)
|
||||
|
||||
conflicts = check_vorgabe_conflicts()
|
||||
self.assertEqual(len(conflicts), 1)
|
||||
|
||||
def test_format_conflict_report_no_conflicts(self):
|
||||
"""Test format_conflict_report with no conflicts"""
|
||||
report = format_conflict_report([])
|
||||
self.assertEqual(report, "✓ No conflicts found in Vorgaben")
|
||||
|
||||
def test_format_conflict_report_with_conflicts(self):
|
||||
"""Test format_conflict_report with conflicts"""
|
||||
# Create a conflicting Vorgabe
|
||||
conflicting_vorgabe = Vorgabe.objects.create(
|
||||
order=3,
|
||||
nummer=1, # Same as vorgabe1
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Conflicting Vorgabe",
|
||||
gueltigkeit_von=date(2023, 6, 1), # Overlaps
|
||||
gueltigkeit_bis=date(2023, 8, 31)
|
||||
)
|
||||
|
||||
conflicts = check_vorgabe_conflicts()
|
||||
report = format_conflict_report(conflicts)
|
||||
|
||||
self.assertIn("Found 1 conflicts:", report)
|
||||
self.assertIn("R0066.O.1", report)
|
||||
self.assertIn("intersecting validity periods", report)
|
||||
|
||||
|
||||
class SanityCheckManagementCommandTest(TestCase):
|
||||
"""Test cases for sanity_check_vorgaben management command"""
|
||||
|
||||
def setUp(self):
|
||||
"""Set up test data for management command tests"""
|
||||
self.dokumententyp = Dokumententyp.objects.create(
|
||||
name="Standard IT-Sicherheit",
|
||||
verantwortliche_ve="SR-SUR-SEC"
|
||||
)
|
||||
self.dokument = Dokument.objects.create(
|
||||
nummer="R0066",
|
||||
dokumententyp=self.dokumententyp,
|
||||
name="IT Security Standard",
|
||||
aktiv=True
|
||||
)
|
||||
self.thema = Thema.objects.create(name="Organisation")
|
||||
|
||||
def test_sanity_check_command_no_conflicts(self):
|
||||
"""Test management command with no conflicts"""
|
||||
out = StringIO()
|
||||
call_command('sanity_check_vorgaben', stdout=out)
|
||||
|
||||
output = out.getvalue()
|
||||
self.assertIn("Starting Vorgaben sanity check...", output)
|
||||
self.assertIn("✓ No conflicts found in Vorgaben", output)
|
||||
|
||||
def test_sanity_check_command_with_conflicts(self):
|
||||
"""Test management command with conflicts"""
|
||||
# Create conflicting Vorgaben
|
||||
Vorgabe.objects.create(
|
||||
order=1,
|
||||
nummer=1,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="First Vorgabe",
|
||||
gueltigkeit_von=date(2023, 1, 1),
|
||||
gueltigkeit_bis=date(2023, 12, 31)
|
||||
)
|
||||
|
||||
Vorgabe.objects.create(
|
||||
order=2,
|
||||
nummer=1, # Same nummer, thema, dokument
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Conflicting Vorgabe",
|
||||
gueltigkeit_von=date(2023, 6, 1), # Overlaps
|
||||
gueltigkeit_bis=date(2023, 8, 31)
|
||||
)
|
||||
|
||||
out = StringIO()
|
||||
call_command('sanity_check_vorgaben', stdout=out)
|
||||
|
||||
output = out.getvalue()
|
||||
self.assertIn("Starting Vorgaben sanity check...", output)
|
||||
self.assertIn("Found 1 conflicts:", output)
|
||||
self.assertIn("R0066.O.1", output)
|
||||
self.assertIn("überschneiden sich in der Geltungsdauer", output)
|
||||
|
||||
|
||||
class IncompleteVorgabenTest(TestCase):
|
||||
"""Test cases for incomplete Vorgaben functionality"""
|
||||
|
||||
def setUp(self):
|
||||
self.client = Client()
|
||||
|
||||
# Create and login a staff user
|
||||
self.staff_user = User.objects.create_user(
|
||||
username='teststaff',
|
||||
password='testpass123'
|
||||
)
|
||||
self.staff_user.is_staff = True
|
||||
self.staff_user.save()
|
||||
self.client.login(username='teststaff', password='testpass123')
|
||||
|
||||
# Create test data
|
||||
self.dokumententyp = Dokumententyp.objects.create(
|
||||
name="Test Typ",
|
||||
verantwortliche_ve="Test VE"
|
||||
)
|
||||
|
||||
self.thema = Thema.objects.create(
|
||||
name="Test Thema",
|
||||
erklaerung="Test Erklärung"
|
||||
)
|
||||
|
||||
self.dokument = Dokument.objects.create(
|
||||
nummer="TEST-001",
|
||||
dokumententyp=self.dokumententyp,
|
||||
name="Test Dokument",
|
||||
gueltigkeit_von=date.today(),
|
||||
aktiv=True
|
||||
)
|
||||
|
||||
# Create complete Vorgabe (should not appear in any list)
|
||||
self.complete_vorgabe = Vorgabe.objects.create(
|
||||
order=1,
|
||||
nummer=1,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Vollständige Vorgabe",
|
||||
gueltigkeit_von=date.today()
|
||||
)
|
||||
|
||||
# Add all required components to make it complete
|
||||
self.stichwort = Stichwort.objects.create(
|
||||
stichwort="Test Stichwort"
|
||||
)
|
||||
self.complete_vorgabe.stichworte.add(self.stichwort)
|
||||
|
||||
self.referenz = Referenz.objects.create(
|
||||
name_nummer="Test Referenz",
|
||||
url="/test/path"
|
||||
)
|
||||
self.complete_vorgabe.referenzen.add(self.referenz)
|
||||
|
||||
VorgabeKurztext.objects.create(
|
||||
abschnitt=self.complete_vorgabe,
|
||||
inhalt="Test Kurztext"
|
||||
)
|
||||
|
||||
Checklistenfrage.objects.create(
|
||||
vorgabe=self.complete_vorgabe,
|
||||
frage="Test Frage"
|
||||
)
|
||||
|
||||
# Create incomplete Vorgaben
|
||||
# 1. Vorgabe without references
|
||||
self.no_refs_vorgabe = Vorgabe.objects.create(
|
||||
order=2,
|
||||
nummer=2,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Vorgabe ohne Referenzen",
|
||||
gueltigkeit_von=date.today()
|
||||
)
|
||||
self.no_refs_vorgabe.stichworte.add(self.stichwort)
|
||||
VorgabeKurztext.objects.create(
|
||||
abschnitt=self.no_refs_vorgabe,
|
||||
inhalt="Test Kurztext"
|
||||
)
|
||||
Checklistenfrage.objects.create(
|
||||
vorgabe=self.no_refs_vorgabe,
|
||||
frage="Test Frage"
|
||||
)
|
||||
|
||||
# 2. Vorgabe without Stichworte
|
||||
self.no_stichworte_vorgabe = Vorgabe.objects.create(
|
||||
order=3,
|
||||
nummer=3,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Vorgabe ohne Stichworte",
|
||||
gueltigkeit_von=date.today()
|
||||
)
|
||||
self.no_stichworte_vorgabe.referenzen.add(self.referenz)
|
||||
VorgabeKurztext.objects.create(
|
||||
abschnitt=self.no_stichworte_vorgabe,
|
||||
inhalt="Test Kurztext"
|
||||
)
|
||||
Checklistenfrage.objects.create(
|
||||
vorgabe=self.no_stichworte_vorgabe,
|
||||
frage="Test Frage"
|
||||
)
|
||||
|
||||
# 3. Vorgabe without text
|
||||
self.no_text_vorgabe = Vorgabe.objects.create(
|
||||
order=4,
|
||||
nummer=4,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Vorgabe ohne Text",
|
||||
gueltigkeit_von=date.today()
|
||||
)
|
||||
self.no_text_vorgabe.stichworte.add(self.stichwort)
|
||||
self.no_text_vorgabe.referenzen.add(self.referenz)
|
||||
Checklistenfrage.objects.create(
|
||||
vorgabe=self.no_text_vorgabe,
|
||||
frage="Test Frage"
|
||||
)
|
||||
|
||||
# 4. Vorgabe without Checklistenfragen
|
||||
self.no_checklisten_vorgabe = Vorgabe.objects.create(
|
||||
order=5,
|
||||
nummer=5,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Vorgabe ohne Checklistenfragen",
|
||||
gueltigkeit_von=date.today()
|
||||
)
|
||||
self.no_checklisten_vorgabe.stichworte.add(self.stichwort)
|
||||
self.no_checklisten_vorgabe.referenzen.add(self.referenz)
|
||||
VorgabeKurztext.objects.create(
|
||||
abschnitt=self.no_checklisten_vorgabe,
|
||||
inhalt="Test Kurztext"
|
||||
)
|
||||
|
||||
def test_incomplete_vorgaben_page_status(self):
|
||||
"""Test that the incomplete Vorgaben page loads successfully"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
def test_incomplete_vorgaben_page_content(self):
|
||||
"""Test that the page contains expected content"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertContains(response, 'Unvollständige Vorgaben')
|
||||
self.assertContains(response, 'Referenzen')
|
||||
self.assertContains(response, 'Stichworte')
|
||||
self.assertContains(response, 'Text')
|
||||
self.assertContains(response, 'Checklistenfragen')
|
||||
# Check for table structure
|
||||
self.assertContains(response, '<table class="table table-striped table-hover">')
|
||||
self.assertContains(response, '<th class="text-center">Referenzen</th>')
|
||||
|
||||
def test_no_references_list(self):
|
||||
"""Test that Vorgaben without references are listed"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertContains(response, 'Vorgabe ohne Referenzen')
|
||||
self.assertNotContains(response, 'Vollständige Vorgabe') # Should not appear
|
||||
|
||||
def test_no_stichworte_list(self):
|
||||
"""Test that Vorgaben without Stichworte are listed"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertContains(response, 'Vorgabe ohne Stichworte')
|
||||
self.assertNotContains(response, 'Vollständige Vorgabe') # Should not appear
|
||||
|
||||
def test_no_text_list(self):
|
||||
"""Test that Vorgaben without Kurz- or Langtext are listed"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertContains(response, 'Vorgabe ohne Text')
|
||||
self.assertNotContains(response, 'Vollständige Vorgabe') # Should not appear
|
||||
|
||||
def test_no_checklistenfragen_list(self):
|
||||
"""Test that Vorgaben without Checklistenfragen are listed"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertContains(response, 'Vorgabe ohne Checklistenfragen')
|
||||
self.assertNotContains(response, 'Vollständige Vorgabe') # Should not appear
|
||||
|
||||
def test_vorgabe_links(self):
|
||||
"""Test that Vorgaben link to their admin pages"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
# Should contain links to Vorgabe admin pages
|
||||
self.assertContains(response, 'href="/autorenumgebung/dokumente/vorgabe/2/change/"')
|
||||
self.assertContains(response, 'href="/autorenumgebung/dokumente/vorgabe/3/change/"')
|
||||
self.assertContains(response, 'href="/autorenumgebung/dokumente/vorgabe/4/change/"')
|
||||
self.assertContains(response, 'href="/autorenumgebung/dokumente/vorgabe/5/change/"')
|
||||
|
||||
def test_badge_counts(self):
|
||||
"""Test that badge counts are correct"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
# Check that JavaScript updates the counts correctly
|
||||
self.assertContains(response, 'id="no-references-count"')
|
||||
self.assertContains(response, 'id="no-stichworte-count"')
|
||||
self.assertContains(response, 'id="no-text-count"')
|
||||
self.assertContains(response, 'id="no-checklistenfragen-count"')
|
||||
# Check total count
|
||||
self.assertContains(response, 'Gesamt: 4 unvollständige Vorgaben')
|
||||
|
||||
def test_summary_section(self):
|
||||
"""Test that summary section shows correct counts"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertContains(response, 'Zusammenfassung')
|
||||
self.assertContains(response, 'Ohne Referenzen')
|
||||
self.assertContains(response, 'Ohne Stichworte')
|
||||
self.assertContains(response, 'Ohne Text')
|
||||
self.assertContains(response, 'Ohne Checklistenfragen')
|
||||
self.assertContains(response, 'Gesamt: 4 unvollständige Vorgaben')
|
||||
|
||||
def test_empty_lists_message(self):
|
||||
"""Test that appropriate messages are shown when lists are empty"""
|
||||
# Delete all incomplete Vorgaben
|
||||
Vorgabe.objects.exclude(pk=self.complete_vorgabe.pk).delete()
|
||||
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertContains(response, 'Alle Vorgaben sind vollständig!')
|
||||
self.assertContains(response, 'Alle Vorgaben haben Referenzen, Stichworte, Text und Checklistenfragen.')
|
||||
|
||||
def test_back_link(self):
|
||||
"""Test that back link to standard list exists"""
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertContains(response, 'href="/dokumente/"')
|
||||
self.assertContains(response, 'Zurück zur Übersicht')
|
||||
|
||||
def test_navigation_link(self):
|
||||
"""Test that navigation includes link to incomplete Vorgaben"""
|
||||
response = self.client.get('/dokumente/')
|
||||
self.assertContains(response, 'href="/dokumente/unvollstaendig/"')
|
||||
self.assertContains(response, 'Unvollständig')
|
||||
|
||||
def test_vorgabe_with_langtext_only(self):
|
||||
"""Test that Vorgabe with only Langtext is still considered incomplete for text"""
|
||||
vorgabe_langtext_only = Vorgabe.objects.create(
|
||||
order=6,
|
||||
nummer=6,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Vorgabe nur mit Langtext",
|
||||
gueltigkeit_von=date.today()
|
||||
)
|
||||
vorgabe_langtext_only.stichworte.add(self.stichwort)
|
||||
vorgabe_langtext_only.referenzen.add(self.referenz)
|
||||
|
||||
# Add only Langtext, no Kurztext
|
||||
VorgabeLangtext.objects.create(
|
||||
abschnitt=vorgabe_langtext_only,
|
||||
inhalt="Test Langtext"
|
||||
)
|
||||
# Add Checklistenfragen to make it complete in that aspect
|
||||
Checklistenfrage.objects.create(
|
||||
vorgabe=vorgabe_langtext_only,
|
||||
frage="Test Frage"
|
||||
)
|
||||
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
# Debug: print response content to see where it appears
|
||||
print("Response content:", response.content.decode())
|
||||
# Should NOT appear in "no text" list because it has Langtext
|
||||
self.assertNotContains(response, 'Vorgabe nur mit Langtext')
|
||||
|
||||
def test_vorgabe_with_both_text_types(self):
|
||||
"""Test that Vorgabe with both Kurztext and Langtext is complete"""
|
||||
vorgabe_both_text = Vorgabe.objects.create(
|
||||
order=7,
|
||||
nummer=7,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Vorgabe mit beiden Texten",
|
||||
gueltigkeit_von=date.today()
|
||||
)
|
||||
vorgabe_both_text.stichworte.add(self.stichwort)
|
||||
vorgabe_both_text.referenzen.add(self.referenz)
|
||||
|
||||
# Add both Kurztext and Langtext
|
||||
VorgabeKurztext.objects.create(
|
||||
abschnitt=vorgabe_both_text,
|
||||
inhalt="Test Kurztext"
|
||||
)
|
||||
VorgabeLangtext.objects.create(
|
||||
abschnitt=vorgabe_both_text,
|
||||
inhalt="Test Langtext"
|
||||
)
|
||||
# Add Checklistenfragen to make it complete in that aspect
|
||||
Checklistenfrage.objects.create(
|
||||
vorgabe=vorgabe_both_text,
|
||||
frage="Test Frage"
|
||||
)
|
||||
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
# Should NOT appear in "no text" list because it has both text types
|
||||
self.assertNotContains(response, 'Vorgabe mit beiden Texten')
|
||||
|
||||
def test_incomplete_vorgaben_staff_only(self):
|
||||
"""Test that non-staff users are redirected to login"""
|
||||
# Logout the staff user
|
||||
self.client.logout()
|
||||
|
||||
# Try to access the page as anonymous user
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertEqual(response.status_code, 302) # Redirect to login
|
||||
|
||||
# Create a regular (non-staff) user
|
||||
regular_user = User.objects.create_user(
|
||||
username='regularuser',
|
||||
password='testpass123'
|
||||
)
|
||||
self.client.login(username='regularuser', password='testpass123')
|
||||
|
||||
# Try to access the page as regular user
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertEqual(response.status_code, 302) # Redirect to login
|
||||
|
||||
# Login as staff user again - should work
|
||||
self.client.login(username='teststaff', password='testpass123')
|
||||
response = self.client.get(reverse('incomplete_vorgaben'))
|
||||
self.assertEqual(response.status_code, 200) # Success
|
||||
|
||||
@@ -3,9 +3,11 @@ from . import views
|
||||
|
||||
urlpatterns = [
|
||||
path('', views.standard_list, name='standard_list'),
|
||||
path('unvollstaendig/', views.incomplete_vorgaben, name='incomplete_vorgaben'),
|
||||
path('<str:nummer>/', views.standard_detail, name='standard_detail'),
|
||||
path('<str:nummer>/history/<str:check_date>/', views.standard_detail),
|
||||
path('<str:nummer>/history/', views.standard_detail, {"check_date":"today"}, name='standard_history'),
|
||||
path('<str:nummer>/checkliste/', views.standard_checkliste, name='standard_checkliste')
|
||||
path('<str:nummer>/checkliste/', views.standard_checkliste, name='standard_checkliste'),
|
||||
path('<str:nummer>/json/', views.standard_json, name='standard_json')
|
||||
]
|
||||
|
||||
|
||||
123
dokumente/utils.py
Normal file
123
dokumente/utils.py
Normal file
@@ -0,0 +1,123 @@
|
||||
"""
|
||||
Utility functions for Vorgaben sanity checking
|
||||
"""
|
||||
import datetime
|
||||
from django.db.models import Count
|
||||
from itertools import combinations
|
||||
from dokumente.models import Vorgabe
|
||||
|
||||
|
||||
def check_vorgabe_conflicts():
|
||||
"""
|
||||
Check for conflicts in Vorgaben.
|
||||
|
||||
Main rule: If there are two Vorgaben with the same number, Thema and Dokument,
|
||||
their valid_from and valid_to date ranges shouldn't intersect.
|
||||
|
||||
Returns:
|
||||
list: List of conflict dictionaries
|
||||
"""
|
||||
conflicts = []
|
||||
|
||||
# Find Vorgaben with same dokument, thema, and nummer
|
||||
duplicate_groups = (
|
||||
Vorgabe.objects.values('dokument', 'thema', 'nummer')
|
||||
.annotate(count=Count('id'))
|
||||
.filter(count__gt=1)
|
||||
)
|
||||
|
||||
for group in duplicate_groups:
|
||||
# Get all Vorgaben in this group
|
||||
vorgaben = Vorgabe.objects.filter(
|
||||
dokument=group['dokument'],
|
||||
thema=group['thema'],
|
||||
nummer=group['nummer']
|
||||
)
|
||||
|
||||
# Check all pairs for date range intersections
|
||||
for vorgabe1, vorgabe2 in combinations(vorgaben, 2):
|
||||
if date_ranges_intersect(
|
||||
vorgabe1.gueltigkeit_von, vorgabe1.gueltigkeit_bis,
|
||||
vorgabe2.gueltigkeit_von, vorgabe2.gueltigkeit_bis
|
||||
):
|
||||
conflicts.append({
|
||||
'vorgabe1': vorgabe1,
|
||||
'vorgabe2': vorgabe2,
|
||||
'conflict_type': 'date_range_intersection',
|
||||
'message': f"Vorgaben {vorgabe1.Vorgabennummer()} and {vorgabe2.Vorgabennummer()} "
|
||||
f"have intersecting validity periods"
|
||||
})
|
||||
|
||||
return conflicts
|
||||
|
||||
|
||||
def date_ranges_intersect(start1, end1, start2, end2):
|
||||
"""
|
||||
Check if two date ranges intersect.
|
||||
None end date means open-ended range.
|
||||
|
||||
Args:
|
||||
start1, start2: Start dates
|
||||
end1, end2: End dates (can be None for open-ended)
|
||||
|
||||
Returns:
|
||||
bool: True if ranges intersect
|
||||
"""
|
||||
# If either start date is None, treat it as invalid case
|
||||
if not start1 or not start2:
|
||||
return False
|
||||
|
||||
# If end date is None, treat it as far future
|
||||
end1 = end1 or datetime.date.max
|
||||
end2 = end2 or datetime.date.max
|
||||
|
||||
# Ranges intersect if start1 <= end2 and start2 <= end1
|
||||
return start1 <= end2 and start2 <= end1
|
||||
|
||||
|
||||
def format_conflict_report(conflicts, verbose=False):
|
||||
"""
|
||||
Format conflicts into a readable report.
|
||||
|
||||
Args:
|
||||
conflicts: List of conflict dictionaries
|
||||
verbose: Whether to show detailed information
|
||||
|
||||
Returns:
|
||||
str: Formatted report
|
||||
"""
|
||||
if not conflicts:
|
||||
return "✓ No conflicts found in Vorgaben"
|
||||
|
||||
lines = [f"Found {len(conflicts)} conflicts:"]
|
||||
|
||||
for i, conflict in enumerate(conflicts, 1):
|
||||
lines.append(f"\n{i}. {conflict['message']}")
|
||||
|
||||
if verbose:
|
||||
v1 = conflict['vorgabe1']
|
||||
v2 = conflict['vorgabe2']
|
||||
|
||||
lines.append(f" Vorgabe 1: {v1.Vorgabennummer()}")
|
||||
lines.append(f" Valid from: {v1.gueltigkeit_von} to {v1.gueltigkeit_bis or 'unlimited'}")
|
||||
lines.append(f" Title: {v1.titel}")
|
||||
|
||||
lines.append(f" Vorgabe 2: {v2.Vorgabennummer()}")
|
||||
lines.append(f" Valid from: {v2.gueltigkeit_von} to {v2.gueltigkeit_bis or 'unlimited'}")
|
||||
lines.append(f" Title: {v2.titel}")
|
||||
|
||||
# Show the overlapping period
|
||||
v1 = conflict['vorgabe1']
|
||||
v2 = conflict['vorgabe2']
|
||||
overlap_start = max(v1.gueltigkeit_von, v2.gueltigkeit_von)
|
||||
overlap_end = min(
|
||||
v1.gueltigkeit_bis or datetime.date.max,
|
||||
v2.gueltigkeit_bis or datetime.date.max
|
||||
)
|
||||
|
||||
if overlap_end != datetime.date.max:
|
||||
lines.append(f" Overlap: {overlap_start} to {overlap_end}")
|
||||
else:
|
||||
lines.append(f" Overlap starts: {overlap_start} (no end)")
|
||||
|
||||
return "\n".join(lines)
|
||||
@@ -1,5 +1,9 @@
|
||||
from django.shortcuts import render, get_object_or_404
|
||||
from .models import Dokument
|
||||
from django.contrib.auth.decorators import login_required, user_passes_test
|
||||
from django.http import JsonResponse
|
||||
from django.core.serializers.json import DjangoJSONEncoder
|
||||
import json
|
||||
from .models import Dokument, Vorgabe, VorgabeKurztext, VorgabeLangtext, Checklistenfrage
|
||||
from abschnitte.utils import render_textabschnitte
|
||||
|
||||
from datetime import date
|
||||
@@ -56,3 +60,180 @@ def standard_checkliste(request, nummer):
|
||||
})
|
||||
|
||||
|
||||
def is_staff_user(user):
|
||||
return user.is_staff
|
||||
|
||||
@login_required
|
||||
@user_passes_test(is_staff_user)
|
||||
def incomplete_vorgaben(request):
|
||||
"""
|
||||
Show table of all Vorgaben with completeness status:
|
||||
- References (✓ or ✗)
|
||||
- Stichworte (✓ or ✗)
|
||||
- Text (✓ or ✗)
|
||||
- Checklistenfragen (✓ or ✗)
|
||||
"""
|
||||
# Get all active Vorgaben
|
||||
all_vorgaben = Vorgabe.objects.all().select_related('dokument', 'thema').prefetch_related(
|
||||
'referenzen', 'stichworte', 'checklistenfragen', 'vorgabekurztext_set', 'vorgabelangtext_set'
|
||||
)
|
||||
|
||||
# Build table data
|
||||
vorgaben_data = []
|
||||
for vorgabe in all_vorgaben:
|
||||
has_references = vorgabe.referenzen.exists()
|
||||
has_stichworte = vorgabe.stichworte.exists()
|
||||
has_kurztext = vorgabe.vorgabekurztext_set.exists()
|
||||
has_langtext = vorgabe.vorgabelangtext_set.exists()
|
||||
has_text = has_kurztext or has_langtext
|
||||
has_checklistenfragen = vorgabe.checklistenfragen.exists()
|
||||
|
||||
# Only include Vorgaben that are incomplete in at least one way
|
||||
if not (has_references and has_stichworte and has_text and has_checklistenfragen):
|
||||
vorgaben_data.append({
|
||||
'vorgabe': vorgabe,
|
||||
'has_references': has_references,
|
||||
'has_stichworte': has_stichworte,
|
||||
'has_text': has_text,
|
||||
'has_checklistenfragen': has_checklistenfragen,
|
||||
'is_complete': has_references and has_stichworte and has_text and has_checklistenfragen
|
||||
})
|
||||
|
||||
# Sort by document number and Vorgabe number
|
||||
vorgaben_data.sort(key=lambda x: (x['vorgabe'].dokument.nummer, x['vorgabe'].Vorgabennummer()))
|
||||
|
||||
return render(request, 'standards/incomplete_vorgaben.html', {
|
||||
'vorgaben_data': vorgaben_data,
|
||||
})
|
||||
|
||||
|
||||
def standard_json(request, nummer):
|
||||
"""
|
||||
Export a single Dokument as JSON
|
||||
"""
|
||||
# Get the document with all related data
|
||||
dokument = get_object_or_404(
|
||||
Dokument.objects.prefetch_related(
|
||||
'autoren', 'pruefende', 'vorgaben__thema',
|
||||
'vorgaben__referenzen', 'vorgaben__stichworte',
|
||||
'vorgaben__checklistenfragen', 'vorgaben__vorgabekurztext_set',
|
||||
'vorgaben__vorgabelangtext_set', 'geltungsbereich_set',
|
||||
'einleitung_set', 'changelog__autoren'
|
||||
),
|
||||
nummer=nummer
|
||||
)
|
||||
|
||||
# Build document structure (reusing logic from export_json command)
|
||||
doc_data = {
|
||||
"Typ": dokument.dokumententyp.name if dokument.dokumententyp else "",
|
||||
"Nummer": dokument.nummer,
|
||||
"Name": dokument.name,
|
||||
"Autoren": [autor.name for autor in dokument.autoren.all()],
|
||||
"Pruefende": [pruefender.name for pruefender in dokument.pruefende.all()],
|
||||
"Gueltigkeit": {
|
||||
"Von": dokument.gueltigkeit_von.strftime("%Y-%m-%d") if dokument.gueltigkeit_von else "",
|
||||
"Bis": dokument.gueltigkeit_bis.strftime("%Y-%m-%d") if dokument.gueltigkeit_bis else None
|
||||
},
|
||||
"SignaturCSO": dokument.signatur_cso,
|
||||
"Geltungsbereich": {},
|
||||
"Einleitung": {},
|
||||
"Ziel": "",
|
||||
"Grundlagen": "",
|
||||
"Changelog": [],
|
||||
"Anhänge": dokument.anhaenge,
|
||||
"Verantwortlich": "Information Security Management BIT",
|
||||
"Klassifizierung": None,
|
||||
"Glossar": {},
|
||||
"Vorgaben": []
|
||||
}
|
||||
|
||||
# Process Geltungsbereich sections
|
||||
geltungsbereich_sections = []
|
||||
for gb in dokument.geltungsbereich_set.all().order_by('order'):
|
||||
geltungsbereich_sections.append({
|
||||
"typ": gb.abschnitttyp.abschnitttyp if gb.abschnitttyp else "text",
|
||||
"inhalt": gb.inhalt
|
||||
})
|
||||
|
||||
if geltungsbereich_sections:
|
||||
doc_data["Geltungsbereich"] = {
|
||||
"Abschnitt": geltungsbereich_sections
|
||||
}
|
||||
|
||||
# Process Einleitung sections
|
||||
einleitung_sections = []
|
||||
for ei in dokument.einleitung_set.all().order_by('order'):
|
||||
einleitung_sections.append({
|
||||
"typ": ei.abschnitttyp.abschnitttyp if ei.abschnitttyp else "text",
|
||||
"inhalt": ei.inhalt
|
||||
})
|
||||
|
||||
if einleitung_sections:
|
||||
doc_data["Einleitung"] = {
|
||||
"Abschnitt": einleitung_sections
|
||||
}
|
||||
|
||||
# Process Changelog entries
|
||||
changelog_entries = []
|
||||
for cl in dokument.changelog.all().order_by('-datum'):
|
||||
changelog_entries.append({
|
||||
"Datum": cl.datum.strftime("%Y-%m-%d"),
|
||||
"Autoren": [autor.name for autor in cl.autoren.all()],
|
||||
"Aenderung": cl.aenderung
|
||||
})
|
||||
|
||||
doc_data["Changelog"] = changelog_entries
|
||||
|
||||
# Process Vorgaben for this document
|
||||
vorgaben = dokument.vorgaben.all().order_by('order')
|
||||
|
||||
for vorgabe in vorgaben:
|
||||
# Get Kurztext and Langtext sections
|
||||
kurztext_sections = []
|
||||
for kt in vorgabe.vorgabekurztext_set.all().order_by('order'):
|
||||
kurztext_sections.append({
|
||||
"typ": kt.abschnitttyp.abschnitttyp if kt.abschnitttyp else "text",
|
||||
"inhalt": kt.inhalt
|
||||
})
|
||||
|
||||
langtext_sections = []
|
||||
for lt in vorgabe.vorgabelangtext_set.all().order_by('order'):
|
||||
langtext_sections.append({
|
||||
"typ": lt.abschnitttyp.abschnitttyp if lt.abschnitttyp else "text",
|
||||
"inhalt": lt.inhalt
|
||||
})
|
||||
|
||||
# Build text structures following Langtext pattern
|
||||
kurztext = {
|
||||
"Abschnitt": kurztext_sections if kurztext_sections else []
|
||||
} if kurztext_sections else {}
|
||||
langtext = {
|
||||
"Abschnitt": langtext_sections if langtext_sections else []
|
||||
} if langtext_sections else {}
|
||||
|
||||
# Get references and keywords
|
||||
referenzen = [f"{ref.name_nummer}: {ref.name_text}" if ref.name_text else ref.name_nummer for ref in vorgabe.referenzen.all()]
|
||||
stichworte = [stw.stichwort for stw in vorgabe.stichworte.all()]
|
||||
|
||||
# Get checklist questions
|
||||
checklistenfragen = [cf.frage for cf in vorgabe.checklistenfragen.all()]
|
||||
|
||||
vorgabe_data = {
|
||||
"Nummer": str(vorgabe.nummer),
|
||||
"Titel": vorgabe.titel,
|
||||
"Thema": vorgabe.thema.name if vorgabe.thema else "",
|
||||
"Kurztext": kurztext,
|
||||
"Langtext": langtext,
|
||||
"Referenz": referenzen,
|
||||
"Gueltigkeit": {
|
||||
"Von": vorgabe.gueltigkeit_von.strftime("%Y-%m-%d") if vorgabe.gueltigkeit_von else "",
|
||||
"Bis": vorgabe.gueltigkeit_bis.strftime("%Y-%m-%d") if vorgabe.gueltigkeit_bis else None
|
||||
},
|
||||
"Checklistenfragen": checklistenfragen,
|
||||
"Stichworte": stichworte
|
||||
}
|
||||
|
||||
doc_data["Vorgaben"].append(vorgabe_data)
|
||||
|
||||
# Return JSON response
|
||||
return JsonResponse(doc_data, json_dumps_params={'indent': 2, 'ensure_ascii': False}, encoder=DjangoJSONEncoder)
|
||||
|
||||
@@ -17,6 +17,9 @@
|
||||
<div class="collapse navbar-collapse" id="navbarNavAltMarkup">
|
||||
<div class="navbar-nav">
|
||||
<a class="nav-item nav-link active" href="/dokumente">Standards</a>
|
||||
{% if user.is_staff %}
|
||||
<a class="nav-item nav-link" href="/dokumente/unvollstaendig/">Unvollständig</a>
|
||||
{% endif %}
|
||||
<a class="nav-item nav-link" href="/referenzen">Referenzen</a>
|
||||
<a class="nav-item nav-link" href="/stichworte">Stichworte</a>
|
||||
<a class="nav-item nav-link" href="/search">Suche</a>
|
||||
@@ -28,6 +31,6 @@
|
||||
<div class="flex-fill">{% block content %}Main Content{% endblock %}</div>
|
||||
<div class="col-md-2">{% block sidebar_right %}{% endblock %}</div>
|
||||
</div>
|
||||
<div>VorgabenUI v0.936</div>
|
||||
<div>VorgabenUI v0.943</div>
|
||||
</body>
|
||||
</html>
|
||||
|
||||
@@ -2,6 +2,12 @@
|
||||
{% block content %}
|
||||
<h1 class="mb-4">Suche</h1>
|
||||
|
||||
{% if error_message %}
|
||||
<div class="alert alert-danger">
|
||||
<strong>Fehler:</strong> {{ error_message }}
|
||||
</div>
|
||||
{% endif %}
|
||||
|
||||
<!-- Search form -->
|
||||
<form action="." method="post">
|
||||
{% csrf_token %}
|
||||
@@ -13,7 +19,9 @@
|
||||
id="query"
|
||||
name="q"
|
||||
placeholder="Suchbegriff eingeben …"
|
||||
required>
|
||||
value="{{ search_term|default:'' }}"
|
||||
required
|
||||
maxlength="200">
|
||||
</div>
|
||||
<button type="submit" class="btn btn-primary">Suchen</button>
|
||||
</form>
|
||||
|
||||
312
pages/tests.py
Normal file
312
pages/tests.py
Normal file
@@ -0,0 +1,312 @@
|
||||
from django.test import TestCase, Client
|
||||
from django.core.exceptions import ValidationError
|
||||
from django.utils import timezone
|
||||
from datetime import date, timedelta
|
||||
from dokumente.models import Dokument, Vorgabe, VorgabeKurztext, VorgabeLangtext, Geltungsbereich, Dokumententyp, Thema
|
||||
from stichworte.models import Stichwort
|
||||
from unittest.mock import patch
|
||||
import re
|
||||
|
||||
|
||||
class SearchViewTest(TestCase):
|
||||
def setUp(self):
|
||||
self.client = Client()
|
||||
|
||||
# Create test data
|
||||
self.dokumententyp = Dokumententyp.objects.create(
|
||||
name="Test Typ",
|
||||
verantwortliche_ve="Test VE"
|
||||
)
|
||||
|
||||
self.thema = Thema.objects.create(
|
||||
name="Test Thema",
|
||||
erklaerung="Test Erklärung"
|
||||
)
|
||||
|
||||
self.dokument = Dokument.objects.create(
|
||||
nummer="TEST-001",
|
||||
dokumententyp=self.dokumententyp,
|
||||
name="Test Dokument",
|
||||
gueltigkeit_von=date.today(),
|
||||
aktiv=True
|
||||
)
|
||||
|
||||
self.vorgabe = Vorgabe.objects.create(
|
||||
order=1,
|
||||
nummer=1,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Test Vorgabe Titel",
|
||||
gueltigkeit_von=date.today()
|
||||
)
|
||||
|
||||
# Create text content
|
||||
self.kurztext = VorgabeKurztext.objects.create(
|
||||
abschnitt=self.vorgabe,
|
||||
inhalt="Dies ist ein Test Kurztext mit Suchbegriff"
|
||||
)
|
||||
|
||||
self.langtext = VorgabeLangtext.objects.create(
|
||||
abschnitt=self.vorgabe,
|
||||
inhalt="Dies ist ein Test Langtext mit anderem Suchbegriff"
|
||||
)
|
||||
|
||||
self.geltungsbereich = Geltungsbereich.objects.create(
|
||||
geltungsbereich=self.dokument,
|
||||
inhalt="Test Geltungsbereich mit Suchbegriff"
|
||||
)
|
||||
|
||||
def test_search_get_request(self):
|
||||
"""Test GET request returns search form"""
|
||||
response = self.client.get('/search/')
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Suche')
|
||||
self.assertContains(response, 'Suchbegriff')
|
||||
|
||||
def test_search_post_valid_term(self):
|
||||
"""Test POST request with valid search term"""
|
||||
response = self.client.post('/search/', {'q': 'Test'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Suchresultate für Test')
|
||||
|
||||
def test_search_case_insensitive(self):
|
||||
"""Test that search is case insensitive"""
|
||||
# Search for lowercase
|
||||
response = self.client.post('/search/', {'q': 'test'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Suchresultate für test')
|
||||
|
||||
# Search for uppercase
|
||||
response = self.client.post('/search/', {'q': 'TEST'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Suchresultate für TEST')
|
||||
|
||||
# Search for mixed case
|
||||
response = self.client.post('/search/', {'q': 'TeSt'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Suchresultate für TeSt')
|
||||
|
||||
def test_search_in_kurztext(self):
|
||||
"""Test search in Kurztext content"""
|
||||
response = self.client.post('/search/', {'q': 'Suchbegriff'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'TEST-001')
|
||||
|
||||
def test_search_in_langtext(self):
|
||||
"""Test search in Langtext content"""
|
||||
response = self.client.post('/search/', {'q': 'anderem'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'TEST-001')
|
||||
|
||||
def test_search_in_titel(self):
|
||||
"""Test search in Vorgabe title"""
|
||||
response = self.client.post('/search/', {'q': 'Titel'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'TEST-001')
|
||||
|
||||
def test_search_in_geltungsbereich(self):
|
||||
"""Test search in Geltungsbereich content"""
|
||||
response = self.client.post('/search/', {'q': 'Geltungsbereich'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Standards mit')
|
||||
|
||||
def test_search_no_results(self):
|
||||
"""Test search with no results"""
|
||||
response = self.client.post('/search/', {'q': 'NichtVorhanden'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Keine Resultate für "NichtVorhanden"')
|
||||
|
||||
def test_search_expired_vorgabe_not_included(self):
|
||||
"""Test that expired Vorgaben are not included in results"""
|
||||
# Create expired Vorgabe
|
||||
expired_vorgabe = Vorgabe.objects.create(
|
||||
order=2,
|
||||
nummer=2,
|
||||
dokument=self.dokument,
|
||||
thema=self.thema,
|
||||
titel="Abgelaufene Vorgabe",
|
||||
gueltigkeit_von=date.today() - timedelta(days=10),
|
||||
gueltigkeit_bis=date.today() - timedelta(days=1)
|
||||
)
|
||||
|
||||
VorgabeKurztext.objects.create(
|
||||
abschnitt=expired_vorgabe,
|
||||
inhalt="Abgelaufener Inhalt mit Test"
|
||||
)
|
||||
|
||||
response = self.client.post('/search/', {'q': 'Test'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
# Should only find the active Vorgabe, not the expired one
|
||||
self.assertContains(response, 'Test Vorgabe Titel')
|
||||
# The expired vorgabe should not appear in results
|
||||
self.assertNotContains(response, 'Abgelaufene Vorgabe')
|
||||
|
||||
def test_search_empty_term_validation(self):
|
||||
"""Test validation for empty search term"""
|
||||
response = self.client.post('/search/', {'q': ''})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Fehler:')
|
||||
self.assertContains(response, 'Suchbegriff darf nicht leer sein')
|
||||
|
||||
def test_search_no_term_validation(self):
|
||||
"""Test validation when no search term is provided"""
|
||||
response = self.client.post('/search/', {})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Fehler:')
|
||||
self.assertContains(response, 'Suchbegriff darf nicht leer sein')
|
||||
|
||||
def test_search_html_tags_stripped(self):
|
||||
"""Test that HTML tags are stripped from search input"""
|
||||
response = self.client.post('/search/', {'q': '<script>alert("xss")</script>Test'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# Should search for "alert('xss')Test" after HTML tag removal
|
||||
self.assertContains(response, 'Suchresultate für alert("xss")Test')
|
||||
|
||||
def test_search_invalid_characters_validation(self):
|
||||
"""Test validation for invalid characters"""
|
||||
response = self.client.post('/search/', {'q': 'Test| DROP TABLE users'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Fehler:')
|
||||
self.assertContains(response, 'Ungültige Zeichen im Suchbegriff')
|
||||
|
||||
def test_search_too_long_validation(self):
|
||||
"""Test validation for overly long search terms"""
|
||||
long_term = 'a' * 201 # 201 characters, exceeds limit of 200
|
||||
response = self.client.post('/search/', {'q': long_term})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'Fehler:')
|
||||
self.assertContains(response, 'Suchbegriff ist zu lang')
|
||||
|
||||
def test_search_max_length_allowed(self):
|
||||
"""Test that exactly 200 characters are allowed"""
|
||||
max_term = 'a' * 200 # Exactly 200 characters
|
||||
response = self.client.post('/search/', {'q': max_term})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# Should not show validation error
|
||||
self.assertNotContains(response, 'Fehler:')
|
||||
|
||||
def test_search_german_umlauts_allowed(self):
|
||||
"""Test that German umlauts are allowed in search"""
|
||||
response = self.client.post('/search/', {'q': 'Test Müller äöü ÄÖÜ ß'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# Should not show validation error
|
||||
self.assertNotContains(response, 'Fehler:')
|
||||
|
||||
def test_search_special_characters_allowed(self):
|
||||
"""Test that allowed special characters work"""
|
||||
response = self.client.post('/search/', {'q': 'Test-Test, Test: Test; Test! Test? (Test) [Test] {Test} "Test" \'Test\''})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# Should not show validation error
|
||||
self.assertNotContains(response, 'Fehler:')
|
||||
|
||||
def test_search_input_preserved_on_error(self):
|
||||
"""Test that search input is preserved on validation errors"""
|
||||
response = self.client.post('/search/', {'q': '<script>Test</script>'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# The input should be preserved (escaped) in the form
|
||||
# Since HTML tags are stripped, we expect "Test" to be searched
|
||||
self.assertContains(response, 'Suchresultate für Test')
|
||||
|
||||
def test_search_xss_prevention_in_results(self):
|
||||
"""Test that search terms are escaped in results to prevent XSS"""
|
||||
# Create content with potential XSS
|
||||
self.kurztext.inhalt = "Content with <script>alert('xss')</script> term"
|
||||
self.kurztext.save()
|
||||
|
||||
response = self.client.post('/search/', {'q': 'term'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# The script tag should be escaped in the output
|
||||
# Note: This depends on how the template renders the content
|
||||
self.assertContains(response, 'Suchresultate für term')
|
||||
|
||||
@patch('pages.views.pprint.pp')
|
||||
def test_search_result_logging(self, mock_pprint):
|
||||
"""Test that search results are logged for debugging"""
|
||||
response = self.client.post('/search/', {'q': 'Test'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# Verify that pprint.pp was called with the result
|
||||
mock_pprint.assert_called_once()
|
||||
|
||||
def test_search_multiple_documents(self):
|
||||
"""Test search across multiple documents"""
|
||||
# Create second document
|
||||
dokument2 = Dokument.objects.create(
|
||||
nummer="TEST-002",
|
||||
dokumententyp=self.dokumententyp,
|
||||
name="Zweites Test Dokument",
|
||||
gueltigkeit_von=date.today(),
|
||||
aktiv=True
|
||||
)
|
||||
|
||||
vorgabe2 = Vorgabe.objects.create(
|
||||
order=1,
|
||||
nummer=1,
|
||||
dokument=dokument2,
|
||||
thema=self.thema,
|
||||
titel="Zweite Test Vorgabe",
|
||||
gueltigkeit_von=date.today()
|
||||
)
|
||||
|
||||
VorgabeKurztext.objects.create(
|
||||
abschnitt=vorgabe2,
|
||||
inhalt="Zweiter Test Inhalt"
|
||||
)
|
||||
|
||||
response = self.client.post('/search/', {'q': 'Test'})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# Should find results from both documents
|
||||
self.assertContains(response, 'TEST-001')
|
||||
self.assertContains(response, 'TEST-002')
|
||||
|
||||
|
||||
class SearchValidationTest(TestCase):
|
||||
"""Test the validate_search_input function directly"""
|
||||
|
||||
def test_validate_search_input_valid(self):
|
||||
"""Test valid search input"""
|
||||
from pages.views import validate_search_input
|
||||
|
||||
result = validate_search_input("Test Suchbegriff")
|
||||
self.assertEqual(result, "Test Suchbegriff")
|
||||
|
||||
def test_validate_search_input_empty(self):
|
||||
"""Test empty search input"""
|
||||
from pages.views import validate_search_input
|
||||
|
||||
with self.assertRaises(ValidationError) as context:
|
||||
validate_search_input("")
|
||||
|
||||
self.assertIn("Suchbegriff darf nicht leer sein", str(context.exception))
|
||||
|
||||
def test_validate_search_input_html_stripped(self):
|
||||
"""Test that HTML tags are stripped"""
|
||||
from pages.views import validate_search_input
|
||||
|
||||
result = validate_search_input("<script>alert('xss')</script>Test")
|
||||
self.assertEqual(result, "alert('xss')Test")
|
||||
|
||||
def test_validate_search_input_invalid_chars(self):
|
||||
"""Test validation of invalid characters"""
|
||||
from pages.views import validate_search_input
|
||||
|
||||
with self.assertRaises(ValidationError) as context:
|
||||
validate_search_input("Test| DROP TABLE users")
|
||||
|
||||
self.assertIn("Ungültige Zeichen im Suchbegriff", str(context.exception))
|
||||
|
||||
def test_validate_search_input_too_long(self):
|
||||
"""Test length validation"""
|
||||
from pages.views import validate_search_input
|
||||
|
||||
with self.assertRaises(ValidationError) as context:
|
||||
validate_search_input("a" * 201)
|
||||
|
||||
self.assertIn("Suchbegriff ist zu lang", str(context.exception))
|
||||
|
||||
def test_validate_search_input_whitespace_stripped(self):
|
||||
"""Test that whitespace is stripped"""
|
||||
from pages.views import validate_search_input
|
||||
|
||||
result = validate_search_input(" Test Suchbegriff ")
|
||||
self.assertEqual(result, "Test Suchbegriff")
|
||||
@@ -1,31 +1,71 @@
|
||||
from django.shortcuts import render
|
||||
from django.core.exceptions import ValidationError
|
||||
from django.utils.html import escape
|
||||
import re
|
||||
from abschnitte.utils import render_textabschnitte
|
||||
from dokumente.models import Dokument, VorgabeLangtext, VorgabeKurztext, Geltungsbereich
|
||||
from dokumente.models import Dokument, VorgabeLangtext, VorgabeKurztext, Geltungsbereich, Vorgabe
|
||||
from itertools import groupby
|
||||
import datetime
|
||||
import pprint
|
||||
|
||||
|
||||
def startseite(request):
|
||||
standards=list(Dokument.objects.filter(aktiv=True))
|
||||
return render(request, 'startseite.html', {"dokumente":standards,})
|
||||
|
||||
def validate_search_input(search_term):
|
||||
"""
|
||||
Validate search input to prevent SQL injection and XSS
|
||||
"""
|
||||
if not search_term:
|
||||
raise ValidationError("Suchbegriff darf nicht leer sein")
|
||||
|
||||
# Remove any HTML tags to prevent XSS
|
||||
search_term = re.sub(r'<[^>]*>', '', search_term)
|
||||
|
||||
# Allow only alphanumeric characters, spaces, and basic punctuation
|
||||
# This prevents SQL injection and other malicious input while allowing useful characters
|
||||
if not re.match(r'^[a-zA-Z0-9äöüÄÖÜß\s\-\.\,\:\;\!\?\(\)\[\]\{\}\"\']+$', search_term):
|
||||
raise ValidationError("Ungültige Zeichen im Suchbegriff")
|
||||
|
||||
# Limit length to prevent DoS attacks
|
||||
if len(search_term) > 200:
|
||||
raise ValidationError("Suchbegriff ist zu lang")
|
||||
|
||||
return search_term.strip()
|
||||
|
||||
def search(request):
|
||||
if request.method == "GET":
|
||||
return render(request, 'search.html')
|
||||
elif request.method == "POST":
|
||||
suchbegriff=request.POST.get("q")
|
||||
raw_search_term = request.POST.get("q", "")
|
||||
|
||||
try:
|
||||
suchbegriff = validate_search_input(raw_search_term)
|
||||
except ValidationError as e:
|
||||
return render(request, 'search.html', {
|
||||
'error_message': str(e),
|
||||
'search_term': escape(raw_search_term)
|
||||
})
|
||||
|
||||
# Escape the search term for display in templates
|
||||
safe_search_term = escape(suchbegriff)
|
||||
result= {"all": {}}
|
||||
qs = VorgabeKurztext.objects.filter(inhalt__contains=suchbegriff).exclude(abschnitt__gueltigkeit_bis__lt=datetime.date.today())
|
||||
qs = VorgabeKurztext.objects.filter(inhalt__icontains=suchbegriff).exclude(abschnitt__gueltigkeit_bis__lt=datetime.date.today())
|
||||
result["kurztext"] = {k: [o.abschnitt for o in g] for k, g in groupby(qs, key=lambda o: o.abschnitt.dokument)}
|
||||
qs = VorgabeLangtext.objects.filter(inhalt__contains=suchbegriff).exclude(abschnitt__gueltigkeit_bis__lt=datetime.date.today())
|
||||
qs = VorgabeLangtext.objects.filter(inhalt__icontains=suchbegriff).exclude(abschnitt__gueltigkeit_bis__lt=datetime.date.today())
|
||||
result['langtext']= {k: [o.abschnitt for o in g] for k, g in groupby(qs, key=lambda o: o.abschnitt.dokument)}
|
||||
qs = Vorgabe.objects.filter(titel__icontains=suchbegriff).exclude(gueltigkeit_bis__lt=datetime.date.today())
|
||||
result['titel']= {k: list(g) for k, g in groupby(qs, key=lambda o: o.dokument)}
|
||||
for r in result.keys():
|
||||
for s in result[r].keys():
|
||||
result["all"][s] = set(result[r][s])
|
||||
if r == 'titel':
|
||||
result["all"][s] = set(result["all"].get(s, set()) | set(result[r][s]))
|
||||
else:
|
||||
result["all"][s] = set(result["all"].get(s, set()) | set(result[r][s]))
|
||||
result["geltungsbereich"]={}
|
||||
geltungsbereich=set(list([x.geltungsbereich for x in Geltungsbereich.objects.filter(inhalt__contains=suchbegriff)]))
|
||||
geltungsbereich=set(list([x.geltungsbereich for x in Geltungsbereich.objects.filter(inhalt__icontains=suchbegriff)]))
|
||||
for s in geltungsbereich:
|
||||
result["geltungsbereich"][s]=render_textabschnitte(s.geltungsbereich_set.order_by("order"))
|
||||
pprint.pp (result)
|
||||
return render(request,"results.html",{"suchbegriff":suchbegriff,"resultat":result})
|
||||
|
||||
return render(request,"results.html",{"suchbegriff":safe_search_term,"resultat":result})
|
||||
|
||||
|
||||
@@ -5,7 +5,6 @@
|
||||
border-radius: 8px;
|
||||
padding: 15px;
|
||||
margin-bottom: 50px;
|
||||
background-color: #f9f9f9;
|
||||
box-shadow: 0 2px 5px rgba(0,0,0,0.1);
|
||||
}
|
||||
|
||||
@@ -38,4 +37,4 @@ tbody.djn-dynamic-form-dokumente-vorgabe td.original p {
|
||||
margin-top: 10px;
|
||||
padding-left: 10px;
|
||||
border-left: 2px dashed #ccc;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,21 +1,58 @@
|
||||
window.addEventListener('load', function () {
|
||||
setTimeout(() => {
|
||||
const vorgabenBlocks = document.querySelectorAll('.djn-dynamic-form-Standards-vorgabe');
|
||||
console.log("Found", vorgabenBlocks.length, "Vorgaben blocks");
|
||||
// Try different selectors for nested admin vorgabe elements
|
||||
const selectors = [
|
||||
'.djn-dynamic-form-dokumente-vorgabe',
|
||||
'.djn-dynamic-form-Standards-vorgabe',
|
||||
'.inline-related[data-inline-type="stacked"]',
|
||||
'.nested-inline'
|
||||
];
|
||||
|
||||
let vorgabenBlocks = [];
|
||||
for (const selector of selectors) {
|
||||
vorgabenBlocks = document.querySelectorAll(selector);
|
||||
if (vorgabenBlocks.length > 0) {
|
||||
console.log("Found", vorgabenBlocks.length, "Vorgaben blocks with selector:", selector);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
if (vorgabenBlocks.length === 0) {
|
||||
console.log("No Vorgaben blocks found, trying fallback...");
|
||||
// Fallback: look for any inline with vorgabe in the class
|
||||
vorgabenBlocks = document.querySelectorAll('[class*="vorgabe"]');
|
||||
}
|
||||
|
||||
vorgabenBlocks.forEach((block, index) => {
|
||||
const header = document.createElement('div');
|
||||
header.className = 'vorgabe-toggle-header';
|
||||
header.innerHTML = `▼ Vorgabe ${index + 1}`;
|
||||
header.style.cursor = 'pointer';
|
||||
|
||||
block.parentNode.insertBefore(header, block);
|
||||
|
||||
header.addEventListener('click', () => {
|
||||
const isHidden = block.style.display === 'none';
|
||||
block.style.display = isHidden ? '' : 'none';
|
||||
header.innerHTML = `${isHidden ? '▼' : '▶'} Vorgabe ${index + 1}`;
|
||||
});
|
||||
// Find the existing title/header within the vorgabe block
|
||||
const existingHeader = block.querySelector('h3, .inline-label, .module h2, .djn-inline-header');
|
||||
|
||||
if (existingHeader) {
|
||||
// Make the existing header clickable for collapse/expand
|
||||
existingHeader.style.cursor = 'pointer';
|
||||
existingHeader.addEventListener('click', (e) => {
|
||||
e.preventDefault();
|
||||
e.stopPropagation();
|
||||
|
||||
// Find all content to collapse - everything except the header itself
|
||||
const allChildren = Array.from(block.children);
|
||||
const contentElements = allChildren.filter(child => child !== existingHeader && !child.contains(existingHeader));
|
||||
|
||||
contentElements.forEach(element => {
|
||||
const isHidden = element.style.display === 'none';
|
||||
element.style.display = isHidden ? '' : 'none';
|
||||
});
|
||||
|
||||
// Update the header text to show collapse state
|
||||
const originalText = existingHeader.textContent.replace(/[▼▶]\s*/, '');
|
||||
const anyHidden = contentElements.some(el => el.style.display === 'none');
|
||||
existingHeader.innerHTML = `${anyHidden ? '▶' : '▼'} ${originalText}`;
|
||||
});
|
||||
|
||||
// Add initial collapse indicator
|
||||
const originalText = existingHeader.textContent;
|
||||
existingHeader.innerHTML = `▼ ${originalText}`;
|
||||
}
|
||||
});
|
||||
}, 500); // wait 500ms to allow nested inlines to render
|
||||
}, 1000); // wait longer to allow nested inlines to render
|
||||
});
|
||||
|
||||
38
test_sanity_check.py
Normal file
38
test_sanity_check.py
Normal file
@@ -0,0 +1,38 @@
|
||||
#!/usr/bin/env python
|
||||
"""
|
||||
Simple script to test Vorgaben sanity checking
|
||||
"""
|
||||
import os
|
||||
import sys
|
||||
import django
|
||||
|
||||
# Setup Django
|
||||
os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'VorgabenUI.settings')
|
||||
django.setup()
|
||||
|
||||
from dokumente.utils import check_vorgabe_conflicts, format_conflict_report
|
||||
|
||||
|
||||
def main():
|
||||
print("Running Vorgaben sanity check...")
|
||||
print("=" * 50)
|
||||
|
||||
# Check for conflicts
|
||||
conflicts = check_vorgabe_conflicts()
|
||||
|
||||
# Generate and display report
|
||||
report = format_conflict_report(conflicts, verbose=True)
|
||||
print(report)
|
||||
|
||||
print("=" * 50)
|
||||
|
||||
if conflicts:
|
||||
print(f"\n⚠️ Found {len(conflicts)} conflicts that need attention!")
|
||||
sys.exit(1)
|
||||
else:
|
||||
print("✅ All Vorgaben are valid!")
|
||||
sys.exit(0)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
Reference in New Issue
Block a user