adebaumann/vgui-cicd
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

All development so far tested and merged into production. #9

Manually merged
adebaumann merged 64 commits from development into main 2025-11-06 15:00:58 +00:00
Conversation 0 Commits 64 Files Changed 39 +7709 -94
adebaumann commented 2025-11-06 14:46:06 +00:00
Owner
Copy Link
No description provided.
adebaumann added 64 commits 2025-11-06 14:46:06 +00:00
Add comprehensive unit tests for dokumente app 4213ca60ac
Fix tests: Update Abschnitttyp to AbschnittTyp af06598172
Fix tests: Update field names to match actual model structure (abschnitttyp field, inhalt field) afc07d4561
Changed tests to be more in line with our terms 957a1b9255
Attempt at improving reference choice in documents 39a2021cc3
Deploy 934 8ce761c248
Add prominent border boxes around each Vorgabe 0bc1fe7413 
- 3px solid blue border (#2c5aa0)
- Increased margin between Vorgaben (30px)
- Added subtle box shadow
- Support both Standards and dokumente class names

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Make Vorgabe titles bigger and more prominent c8755e4339 
- Increased font size to 18px with bold weight (700)
- Blue color (#2c5aa0) matching the border
- Light blue gradient background
- Bottom border separator
- Extends full width with negative margins

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Make Vorgabe identifier text in tabular view prominent 9610024739 
Styled the td.original cell containing Vorgabe identifiers (e.g., "R0066.O.3: Dateninhaber"):
- Font size: 16px
- Font weight: 700 (bold)
- Blue color matching border (#2c5aa0)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Fix selector for tabular Vorgabe identifiers with tbody target 1146506ca2 
Changed selector to target tbody.djn-dynamic-form-dokumente-vorgabe and added !important to override existing styles.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Increase whitespace between Vorgabe boxes 886baa163e 
Increased margin-bottom from 30px to 50px for better visual separation between Vorgaben.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Deploy 935 ddf035c50f
added 'aktiv' to dokument (so people can play around with standards) 650fe0a87b
Deploy 936 a437af554b
Merge branch 'feature/dokumente-unit-tests' into development 96819a7427
Added 'aktiv' to document tests 7befde104d
Corrections on Dokumente-Admin; Homepage now only shows active documents 6654779e67
Deploy 937 5609a735f4
Make Vorgaben draggable; Deploy 938 a42a65b40f
Date 'bis None' changed to 'bis auf weiteres' 2afada0bce
Tests for documents fixed (Vorgabe-Order added) 6df72c95cb
Add comprehensive tests for Textabschnitte app 8860947d38 
- Add 41 comprehensive test cases covering all functionality
- Test AbschnittTyp model creation and validation
- Test Textabschnitt abstract model through VorgabeLangtext
- Test all rendering types: text, lists, tables, code, diagrams
- Test markdown rendering with footnotes and formatting
- Test table conversion from markdown to Bootstrap HTML
- Test diagram caching with mocked external service calls
- Test diagram error handling and custom options
- Test clear_diagram_cache management command
- Test integration with dokumente models
- All tests passing (41/41)
.gitignore extended by npm stuff 4d2ffeea27
Merge branch 'feature/textabschnitte-comprehensive-tests' into development 1ce8eb15c0
Tabular view for Vorgaben added 8bca1bb3c7
Deploy 939 94363d49ce
Borders work, collapsing doesn't yet b0c9b89e94
Horizontal fieldsets OK d4143da9fc
Collapsing and drag/drop implemented a075811173
background of Vorgaben changed - looks better in dark mode. 081ea4de1c
Deploy 940 d14d9eba4c
Removed "Ändern" and "Löschen"-Links aca9a2f307
Add Vorgaben sanity check functionality 779604750e 
Implement comprehensive validation system to detect conflicting Vorgaben with overlapping validity periods.

Features:
- Static method Vorgabe.sanity_check_vorgaben() for global conflict detection
- Instance method Vorgabe.find_conflicts() for individual conflict checking
- Model validation via Vorgabe.clean() to prevent conflicting data
- Utility functions for date range intersection and conflict reporting
- Django management command 'sanity_check_vorgaben' for manual checks
- Comprehensive test suite with 17 new tests covering all functionality

Validation logic ensures Vorgaben with same dokument, thema, and nummer cannot have overlapping gueltigkeit_von/gueltigkeit_bis date ranges. Handles open-ended ranges (None end dates) and provides clear error messages.

Files added/modified:
- dokumente/models.py: Added sanity check methods and validation
- dokumente/utils.py: New utility functions for conflict detection
- dokumente/management/commands/sanity_check_vorgaben.py: New management command
- dokumente/tests.py: Added comprehensive test coverage
- test_sanity_check.py: Standalone test script

All tests pass (56/56) with no regressions.
Changed edge case in date validation for Vorgaben 7e4d2fa29b
Deploy 941 - new database 48bf8526b9
Merge branch 'feature/sanitychecks' into development 898e9b8163
Translated 'rogue' English error message 28a1bb4b62
Enhance search functionality with case-insensitive title search and security improvements 671d259c44 
- Add case-insensitive search across all fields (inhalt, titel, geltungsbereich)
- Include Vorgabe.titel field in search scope for better coverage
- Implement comprehensive input validation against SQL injection and XSS
- Add German error messages for validation failures
- Escape search terms in templates to prevent XSS attacks
- Add input length limits and character validation
- Preserve user input on validation errors for better UX
Enhance search functionality with case-insensitive title search, security improvements, and comprehensive tests 2350cca32c 
- Add case-insensitive search across all fields (inhalt, titel, geltungsbereich)
- Include Vorgabe.titel field in search scope for better coverage
- Implement comprehensive input validation against SQL injection and XSS
- Add German error messages for validation failures
- Escape search terms in templates to prevent XSS attacks
- Add input length limits and character validation
- Preserve user input on validation errors for better UX
- Add comprehensive test suite with 27 tests covering all functionality
- Test security features: XSS prevention, SQL injection protection, input validation
- Test edge cases: expired content, multiple documents, German umlauts
- Ensure all search fields work correctly with case-insensitive matching
feat: incomplete Vorgaben page implementation 6aefb046b6 
## New Incomplete Vorgaben Page
- Created new incomplete_vorgaben view in dokumente/views.py
- Added URL pattern /dokumente/unvollstaendig/ in dokumente/urls.py
- Built responsive Bootstrap template showing 4 categories of incomplete Vorgaben:
  1. Vorgaben without references
  2. Vorgaben without Stichworte
  3. Vorgaben without Kurz- or Langtext
  4. Vorgaben without Checklistenfragen
- Added navigation link "Unvollständig" to main menu
- Created comprehensive test suite with 14 test cases covering all functionality
- All incomplete Vorgaben tests now passing (14/14)

## Bug Fixes and Improvements
- Fixed model field usage: corrected Referenz model field names (name_nummer, url)
- Fixed test logic: corrected test expectations and data setup for accurate validation
- Fixed template styling: made badge styling consistent across all sections
- Removed debug output: cleaned up print statements for production readiness
- Enhanced test data creation to use correct model field names

## Test Coverage
- Total tests: 41/41 passing
- Search functionality: 27 tests covering validation, security, case-insensitivity, and content types
- Incomplete Vorgaben: 14 tests covering page functionality, data categorization, and edge cases
- Both features are fully tested and production-ready

## Security Enhancements
- Input validation prevents SQL injection attempts
- HTML escaping prevents XSS attacks in search results
- Length validation prevents buffer overflow attempts
- Character validation ensures only appropriate input is processed

The application now provides robust search capabilities with comprehensive security measures and a valuable content management tool for identifying incomplete Vorgaben entries.
Fixed tests - expecting English and getting German, now expect German faae37e6ae
Unvollständige Vorgaben nur noch für Admins da1deac44e
Deploy 942 7186fa2cbe
Tests corrected, 'Thema' is now required (produces errors otherwise) 2b41490806
feat: enhance incomplete Vorgaben page with table layout and admin integration cb374bfa77 
- Redesign incomplete Vorgaben page from card layout to unified table format
- Add visual status indicators (✓/✗) for each completeness category
- Link Vorgaben directly to admin edit pages (/autorenumgebung/ instead of /admin/)
- Enhance Vorgabe admin with Kurztext and Langtext inlines for complete editing
- Update all tests to work with new table structure and admin URLs
- Add JavaScript for dynamic summary count updates
- Maintain staff-only access control and responsive design

All 112 tests passing successfully.
Merge branch 'development' into feature/list-of-incomplete-vorgaben b82c6fea38
Merge pull request 'feat: enhance incomplete Vorgaben page with table layout and admin integration' (#4) from feature/list-of-incomplete-vorgaben into development 8153aa56ce 
Reviewed-on: #4
Added early JSON file for reference af4e1c61aa
feat: add comprehensive JSON export command for dokumente 3ccb32e8e1 
- Add Django management command 'export_json' for exporting all dokumente data
- Implement structured JSON format with proper section types from database
- Include all document fields: gueltigkeit, signatur_cso, anhaenge, changelog
- Support Kurztext, Geltungsbereich, Einleitung with Langtext-style structure
- Use actual abschnitttyp values instead of hardcoded 'text'
- Handle Referenz model fields correctly (name_nummer, name_text)
- Support --output parameter for file export or stdout by default
JSON functionality extended to website. Tests pending. af636fe6ea
Merge pull request 'feature/json' (#6) from feature/json into development 994ba5d797 
Reviewed-on: #6
.env ignored 0cd09d0878
Deploy 943 e94f61a697
Better 'Stichwort' admin pages 8520412867
Deploy 944 f7e6795c00
Cleanup in Dockerfile 9d4c7d5f87
Removed diagram proxy - no longer needed because of cacheing function 28f87509d6
Deploy 945 9bd4cb19d3
Merge branch 'cleanup/remove-diagram-proxy' into development b8d5bc796d
Merge pull request 'Better 'Stichwort' admin pages' (#7) from improvement/admin-tweaks into development 4b15c5f173 
Reviewed-on: #7
Add comprehensive test suites and documentation 277a24bb50 
- Add complete test coverage for referenzen, rollen, and stichworte apps
- Implement 54 new tests covering models, relationships, and business logic
- Fix MPTT method names and import issues in test implementations
- Create comprehensive test documentation in English and German
- All 188 tests now passing across all Django apps

Test coverage breakdown:
- referenzen: 18 tests (MPTT hierarchy, model validation)
- rollen: 18 tests (role models, relationships)
- stichworte: 18 tests (keyword models, ordering)
- Total: 54 new tests added

Documentation:
- Test suite.md: Complete English documentation
- Test Suite-DE.md: Complete German documentation
Add comprehensive JSON generation tests and update documentation 733a437ae0 
- Add 9 new JSON export tests in dokumente/test_json.py
- Add 9 JSON tests to main dokumente/tests.py
- Fix Geltungsbereich field name issues in test setup
- Update test documentation with JSON test coverage
- Update test counts: Total 206 tests (was 188)
- JSON tests cover both management command and view functionality
- Tests include file output, stdout, error handling, and edge cases
- All 206 tests now passing
Merge branch 'development' into feature/add-missing-tests 69ca9bce4d
Merge pull request 'feature/add-missing-tests' (#8) from feature/add-missing-tests into development 26d62014c9 
Reviewed-on: #8
adebaumann manually merged commit ff652d6f90 into main 2025-11-06 15:00:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adebaumann
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adebaumann/vgui-cicd#9
No description provided.
Delete Branch "development"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?